Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native modules linking in 0.29.1 #8807

Closed
wants to merge 2 commits into from

Conversation

Kureev
Copy link
Contributor

@Kureev Kureev commented Jul 15, 2016

Motivation

Attempt to fix #8612

Description

We re-named mainActivityPath by mainFilePath in the link code, but we forgot to rename config parameters. Currently, link is broken.

Test plan (required)

  • react-native link should work for react-native 0.29+

@ghost
Copy link

ghost commented Jul 15, 2016

By analyzing the blame information on this pull request, we identified @grabbou and @mkonicek to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 15, 2016
@grabbou
Copy link
Contributor

grabbou commented Jul 15, 2016

Thanks, taking a look now

@satya164
Copy link
Contributor

Let's release 0.29.2 with this fix.

@grabbou
Copy link
Contributor

grabbou commented Jul 15, 2016

That's the plan @satya164, just waiting for confirmation from @Kureev on Messanger that he tested few things out and we are shipping

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2016
@Kureev
Copy link
Contributor Author

Kureev commented Jul 16, 2016

Added missing import patch fix. Everything works now.

@Kureev
Copy link
Contributor Author

Kureev commented Jul 16, 2016

Ready for review, @satya164 @grabbou

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2016
@satya164
Copy link
Contributor

LGTM 👍

@Kureev
Copy link
Contributor Author

Kureev commented Jul 16, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 16, 2016
@ghost
Copy link

ghost commented Jul 16, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2016
@ghost ghost closed this in 3c8a2ee Jul 16, 2016
grabbou pushed a commit that referenced this pull request Jul 17, 2016
Summary:
Attempt to fix #8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes #8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
@greenteamer
Copy link

greenteamer commented Jul 18, 2016

Hi, @grabbou @Kureev! Your work speed is a great example for me, and with realm we have not any problems so thank you! But now I have "incompatible types: cannot be converted to Context new CodePush(null, this, BuildConfig.DEBUG)," with react-native link react-native-code-push

@greenteamer
Copy link

in manual react-native-code-push we must getting new CodePush(null, MainApplication.this, BuildConfig.DEBUG) but we getting new CodePush(null, this, BuildConfig.DEBUG), like for react-native <= 0.28

@Kureev
Copy link
Contributor Author

Kureev commented Jul 18, 2016

Hey, @greenteamer!

What about patching code-push packge.json by this:

"rnpm": {
  "android": {
    "packageInstance": "new CodePush(null, MainApplication.this, BuildConfig.DEBUG)"
  }
}

?

grabbou pushed a commit that referenced this pull request Jul 21, 2016
Summary:
Attempt to fix #8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes #8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
samerce pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
Attempt to fix facebook#8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes facebook#8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
Attempt to fix facebook#8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes facebook#8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
Attempt to fix facebook/react-native#8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes facebook/react-native#8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
Summary:
Attempt to fix facebook/react-native#8612

We re-named `mainActivityPath` by `mainFilePath` in the `link` code, but we forgot to rename config parameters. Currently, link is broken.

- [x] `react-native link` should work for react-native 0.29+
Closes facebook/react-native#8807

Differential Revision: D3576176

fbshipit-source-id: 60ecbd660563923696bbef1ed3b0900a7d58469f
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants