[Android] Fixed the issue due to which js assets are not bundled in the apk when separate build for different CPU architectures is enabled #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cpu architecture is enabled, `bundleJsAndAssets` task is not run even in release builds.
|
By analyzing the blame information on this pull request, we identified @AndrewJack and @philikon to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
|
@grabbou we should cherry-pick this to 0.29 and 0.30 |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
grabbou
pushed a commit
that referenced
this pull request
Jul 13, 2016
…n separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes #8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476
grabbou
pushed a commit
that referenced
this pull request
Jul 21, 2016
…n separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes #8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
…n separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes facebook#8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
…n separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes facebook#8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
…n separate build for different CPU architectures is enabled Summary: This PR tries to fix a minor bug in `react.gradle` due to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors. Closes facebook/react-native#8675 Differential Revision: D3541348 fbshipit-source-id: 4c84f21a06a45046f84bdd8ae5c5d834ec080476
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a minor bug in
react.gradledue to which task that bundles JS into the assets folder of the APK is not run when separate build per CPU architecture is enabled and we are using different product flavors.