Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link against MainApplication.java #8642

Closed
wants to merge 1 commit into from
Closed

Link against MainApplication.java #8642

wants to merge 1 commit into from

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Jul 7, 2016

Fixes #8603

To be cherry-picked into 0.29-stable later.

CC: @Kureev (mind testing? I am on holidays internet till Sunday)

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 7, 2016
@grabbou
Copy link
Contributor Author

grabbou commented Jul 7, 2016 •
edited
Loading

There's an alternative PR made by @GantMan #8612 that I missed, I don't mind closing this one and merging GantMan's one :)

@grabbou grabbou closed this Jul 7, 2016
@grabbou grabbou deleted the fix/rnpm-0.29 branch August 3, 2016 12:30
react-one pushed a commit to react-one/react-native that referenced this pull request Sep 24, 2021
@satya164
fix: only offset bottom tab on iOS. fixes facebook#8642
d979dfd
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grabbou @facebook-github-bot