Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional docdown commits to 0.29 #8492

Merged
merged 2 commits into from
Jun 29, 2016
Merged

Additional docdown commits to 0.29 #8492

merged 2 commits into from
Jun 29, 2016

Conversation

JoelMarcey
Copy link

7ac931e added most of our documentation lockdown commits to the next release (0.29). This adds one more major document that just landed (NavigationExperimental guide) and a minor color change.

Test Plan:

screencapture-localhost-8079-react-native-docs-navigator-comparison-html-1467213398775

screencapture-localhost-8079-react-native-docs-asyncstorage-html-1467213424524

hramos and others added 2 commits June 29, 2016 08:12
Summary:
Add a NavigationExperimental section to the Navigation guide.

![navexp](https://cloud.githubusercontent.com/assets/165856/16355280/120e7d38-3a67-11e6-9567-51c19c249fdf.png)
Closes #8431

Differential Revision: D3493158

Pulled By: JoelMarcey

fbshipit-source-id: 5e9646c3abf97f5cce6f5ba5b3d10853aa84ee8e
Summary: Closes #8481

Differential Revision: D3497267

Pulled By: JoelMarcey

fbshipit-source-id: 82ffb17a9ec3110481ad64d5065fc9fee6a31808
@ghost
Copy link

ghost commented Jun 29, 2016

By analyzing the blame information on this pull request, we identified @hramos and @caabernathy to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 29, 2016
@bestander bestander merged commit 17b1272 into facebook:0.29-stable Jun 29, 2016
@bestander
Copy link
Contributor

cc @grabbou, this one was picked into 0.29

@grabbou
Copy link
Contributor

grabbou commented Jun 30, 2016

Ok, thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants