Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RCTAnimation to Podspec #8487

Closed
wants to merge 1 commit into from
Closed

Add RCTAnimation to Podspec #8487

wants to merge 1 commit into from

Conversation

oblador
Copy link
Contributor

@oblador oblador commented Jun 29, 2016

Motivation

This PR adds a subspec for the NativeAnimation iOS library which so one can use it with CocoaPods.

Test plan (required)

Tested with the code in NativeAnimationsExample.js and this:

pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native'

@ghost
Copy link

ghost commented Jun 29, 2016

By analyzing the blame information on this pull request, we identified @alloy and @nevir to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 29, 2016
@ide
Copy link
Contributor

ide commented Jun 30, 2016

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 30, 2016
@ghost
Copy link

ghost commented Jun 30, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 4a15dc8 Jun 30, 2016
ide pushed a commit that referenced this pull request Jul 2, 2016
@oblador @ide
Add RCTAnimation to Podspec
9f9408a 
Summary:
**Motivation**

This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods.

**Test plan (required)**

Tested with the code in `NativeAnimationsExample.js` and this:
```
pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native'
```
Closes #8487

Differential Revision: D3502970

fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@oblador @bubblesunyum
Add RCTAnimation to Podspec
8132bc7 
Summary:
**Motivation**

This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods.

**Test plan (required)**

Tested with the code in `NativeAnimationsExample.js` and this:
```
pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native'
```
Closes facebook#8487

Differential Revision: D3502970

fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@oblador
Add RCTAnimation to Podspec
6250806 
Summary:
**Motivation**

This PR adds a subspec for the `NativeAnimation` iOS library which so one can use it with CocoaPods.

**Test plan (required)**

Tested with the code in `NativeAnimationsExample.js` and this:
```
pod 'React', :subspecs => ['Core', 'RCTAnimation'], :path => 'node_modules/react-native'
```
Closes facebook#8487

Differential Revision: D3502970

fbshipit-source-id: 0958acdbe088da8b50a1e5e3661f27b64db329c1
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oblador @ide