Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigator comparison and redirect to Navigation guide #8411

Closed
wants to merge 4 commits into from
Closed

Remove navigator comparison and redirect to Navigation guide #8411

wants to merge 4 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jun 24, 2016

The new Navigation guide replaces the Navigator comparison doc. The server will redirect from navigator-comparison.html to navigation.html when this lands.

@ghost
Copy link

ghost commented Jun 24, 2016

By analyzing the blame information on this pull request, we identified @caabernathy and @alvaromb to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 24, 2016
@hramos
Copy link
Contributor Author

hramos commented Jun 24, 2016

Think of it, the earlier redirect was not going to work properly in the generated static site. I'm fine with keeping the navigator-comparison.html permalink in order to avoid dealing with redirects.

@caabernathy
Copy link
Contributor

So is this PR still applicable since you mentioned you wanted to revert?

@hramos
Copy link
Contributor Author

hramos commented Jun 24, 2016

@caabernathy there is some content updates in this PR, but given the revert I think it makes more sense to split this into two new PRs.

@hramos hramos closed this Jun 24, 2016
@hramos hramos deleted the lockdown-navigator-comparison branch June 24, 2016 17:00
@hramos
Copy link
Contributor Author

hramos commented Jun 24, 2016

See #8417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants