Fixed incorrect style props passed to Android Image when using children

[jeanregisser]

Hi there,

Here is a fix for #7538 (and #5085).

I had originally discovered this issue when using resizeMode through the style props. Although this might arguably be an incorrect usage (see #4759 (comment)) the same issue would happen with the tintColor and overlayColor style props.

To test this, you can render the following:

const imageContainerStyle = {width: 100, height: 100, backgroundColor: 'green', marginLeft: 10, marginTop: 10, };
const imageStyle = {flex: 1, width: undefined, height: undefined, resizeMode: 'contain', };

return (
  <View style={styles.container}>
    <View style={imageContainerStyle}>
      <Image style={imageStyle} source={
        {uri:'http://resizing.flixster.com/DeLpPTAwX3O2LszOpeaMHjbzuAw=/53x77/dkpu1ddg7pbsk.cloudfront.net/movie/11/16/47/11164719_ori.jpg'} 
      }>
      </Image>
    </View>
    <View style={imageContainerStyle}>
      <Image style={imageStyle} source={
        {uri:'http://resizing.flixster.com/DeLpPTAwX3O2LszOpeaMHjbzuAw=/53x77/dkpu1ddg7pbsk.cloudfront.net/movie/11/16/47/11164719_ori.jpg'}  
      }>
        <View style={{width: 20, height: 20, backgroundColor: 'blue'}} />
      </Image>
    </View>
  </View>
);

And verify that the second image (with the blue square) resizeMode is still correct and displays exactly as in the first image.
You can also substitute resizeMode with tintColor or overlayColor.

I tried to make the fix robust so it wouldn't introduce new issues if new style props were added to the Image component.
When the Image module is loaded, it intersects the View style props with the Image style props to extract the style props that are specific to the Image style. Right now the props are: resizeMode, tintColor and overlayColor (this one is Android only).

Let me know what you think.

[ghost]

By analyzing the blame information on this pull request, we identified @andreicoman11 and @cornedor to be potential reviewers.

[andreicoman11]

This looks good to me. Thanks!

[andreicoman11]

@facebook-github-bot shipit

[ghost]

Thanks for importing. If you are an FB employee go to Phabricator to review.