Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds log-ios and log-android cli commands #8352

Closed
wants to merge 1 commit into from
Closed

adds log-ios and log-android cli commands #8352

wants to merge 1 commit into from

Conversation

vitalis
Copy link
Contributor

@vitalis vitalis commented Jun 23, 2016

solves first part of #8186

@ghost
Copy link

ghost commented Jun 23, 2016

By analyzing the blame information on this pull request, we identified @janicduplessis and @hramos to be potential reviewers.

@ghost
Copy link

ghost commented Jun 23, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

mkonicek
mkonicek reviewed Jun 23, 2016
View reviewed changes
local-cli/logAndroid/logAndroid.js
));
// stderr is automatically piped from the gradle process, so the user
// should see the error already, there is no need to do
// `console.log(e.stderr)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably remove these lines (copied from run-android, mentions gradle).

@mkonicek
Copy link
Contributor

Reviewed in the Tel Aviv hackathon.

@facebook-github-bot shipit

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 23, 2016
@ghost
Copy link

ghost commented Jun 23, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 39f524d Jun 23, 2016
@mkonicek mkonicek mentioned this pull request Jun 23, 2016
Closed
mkonicek pushed a commit that referenced this pull request Jul 1, 2016
@vitalis
adds log-ios and log-android cli commands
cf97c9a 
Summary:
solves first part of #8186
Closes #8352

Differential Revision: D3475905

Pulled By: mkonicek

fbshipit-source-id: 99f6aa15b92ba3192fa0b812d369bd7020469573
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@vitalis @bubblesunyum
adds log-ios and log-android cli commands
75028f6 
Summary:
solves first part of facebook#8186
Closes facebook#8352

Differential Revision: D3475905

Pulled By: mkonicek

fbshipit-source-id: 99f6aa15b92ba3192fa0b812d369bd7020469573
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@vitalis
adds log-ios and log-android cli commands
615e71b 
Summary:
solves first part of facebook#8186
Closes facebook#8352

Differential Revision: D3475905

Pulled By: mkonicek

fbshipit-source-id: 99f6aa15b92ba3192fa0b812d369bd7020469573
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@vitalis
adds log-ios and log-android cli commands
7708614 
Summary:
solves first part of #8186
Closes facebook/react-native#8352

Differential Revision: D3475905

Pulled By: mkonicek

fbshipit-source-id: 99f6aa15b92ba3192fa0b812d369bd7020469573
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitalis @mkonicek