[NavigationExperimental] Migrate NavigationCardStack #8268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @hedgerwang and @ericvicenti to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@ericvicenti For NavigationCardStack, do we want to stay opinionated on issues mentioned in #7210? @hedgerwang fixed that in 3a62314. Not sure if we should follow the same path for CardStack though. It would only add additional complexity to the examples and I don't think it's worth it. |
jmurzy
force-pushed
the
migrate-cardstack
branch
from
998d153 to
4c8e8cc
Compare
jmurzy
force-pushed
the
migrate-cardstack
branch
from
4c8e8cc to
05cc24c
Compare
jmurzy
changed the title
| if (this.props.renderOverlay) { | ||
| const route = navigationState.routes[navigationState.index]; | ||
|
|
||
| const activeScene = props.scenes.find( |
There was a problem hiding this comment.
call of method renderOverlay Function cannot be called on possibly undefined value undefined
There was a problem hiding this comment.
call of method renderOverlay Function cannot be called on possibly null value null
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
jmurzy
referenced
this pull request
Jun 21, 2016
Summary: - Fork NavigationAnimatedView to NavigationTransitioner - NavigationAnimatedView will soon be deprecated and we'd ask people to use NavigationTransitioner instead. Difference between NavigationTransitioner and NavigationAnimatedView - prop `applyAnimation` is removed. - new prop `configureTransition`, `onTransitionStart`, and `onTransitionEnd` are added. tl;dr; In NavigationAnimatedView, we `position` (an Animated.Value object) as a proxy of the transtion which happens whenever the index of navigation state changes. Because `position` does not change unless navigation index changes, it won't be possible to build animations for actions that changes the navigation state without changing the index. Also, we believe that the name `Transitioner` is a better name for this core component that focuses on transitioning. Note that the actual animation work is done via `<Animated.View />` returnd from the `renderScene` prop. Reviewed By: ericvicenti Differential Revision: D3302688 fbshipit-source-id: 720c3a4d3ccf97eb05b038baa44c9e780aad120b
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: As discussed in facebook#8262. Closes facebook#8268 Reviewed By: hedgerwang Differential Revision: D3462059 Pulled By: ericvicenti fbshipit-source-id: 1f48db3a15668e5a1122b7dcb244bd4352acf9a9
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: As discussed in facebook#8262. Closes facebook#8268 Reviewed By: hedgerwang Differential Revision: D3462059 Pulled By: ericvicenti fbshipit-source-id: 1f48db3a15668e5a1122b7dcb244bd4352acf9a9
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #8262.