Added logging to push registration failure. #8046
Conversation
It seems it's a common problem people trying to register for push notifications in their simulator, and not understanding why the "register" event never works. I've wasted a few hours myself on this issue. This commit simply logs any failures with push registration, preventing confusion.
|
By analyzing the blame information on this pull request, we identified @nicklockwood and @slycoder to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
cc @javache |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Summary: It seems it's a common problem people trying to register for push notifications in their simulator, and not understanding why the "register" event never works. I've wasted a few hours myself on this issue. This commit simply logs any failures with push registration, preventing confusion. Closes facebook#8046 Differential Revision: D3454922 Pulled By: javache fbshipit-source-id: a96896d97d97cfe1bd319e6490750838dfaad3cd
Summary: It seems it's a common problem people trying to register for push notifications in their simulator, and not understanding why the "register" event never works. I've wasted a few hours myself on this issue. This commit simply logs any failures with push registration, preventing confusion. Closes facebook#8046 Differential Revision: D3454922 Pulled By: javache fbshipit-source-id: a96896d97d97cfe1bd319e6490750838dfaad3cd
It seems it's a common problem people trying to register for push notifications in their simulator, and not understanding why the "register" event never works.
I've wasted a few hours myself on this issue.
This commit simply logs any failures with push registration, preventing confusion.