Getting Started Cleanup #7477
Closed
Getting Started Cleanup #7477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @willfong and @DavidYKay to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -52,7 +52,7 @@ block { display: none; } | |||
|
|
|||
| <div>Unfortunately, Apple only lets you develop for iOS on a Mac machine. Please check out the <a href="" onclick="display('platform', 'android')">Android</a> instructions instead.</div> | |||
|
|
|||
| <center><img src="https://fbcdn-dragon-a.akamaihd.net/hphotos-ak-xaf1/t39.1997-6/851591_233289256829505_447005964_n.png" width="150"></img></center> | |||
|  | |||
There was a problem hiding this comment.
you are missing the <center> and width
<center><img src="img/react-native-sorry-not-supported.png" width="150"></img></center>
|
@JoelMarcey updated the pull request. |
1. Remove note about upgrading homebrew pacakges. That was kind of noisy. 2. Use local images instead of those stored on Akamai. 3. Add wording for modifying test project about actually opening a file. 4. Add note about keeping initial defaults for Android Studio in tact
|
@JoelMarcey updated the pull request. |
|
Feel free to shipit |
|
@facebook-github-bot shipit |
ghost
added
the
Import Started
|
@facebook-github-bot shipit |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
@facebook-github-bot shipit |
JoelMarcey
added a commit
that referenced
this pull request
May 10, 2016
Summary: 1. Remove note about upgrading Homebrew packages. That was kind of noisy. 2. Use local images instead of those stored on Akamai. 3. Add wording for modifying test project about actually opening a file. 4. Add note about keeping initial defaults for Android Studio install in tact. Tested site locally. Images and new wording appeared as expected. Closes #7477 Reviewed By: vjeux Differential Revision: D3281639 Pulled By: JoelMarcey fbshipit-source-id: ca956d97293ac3793431cb54f3560ee3e52c0dce
JoelMarcey
added a commit
that referenced
this pull request
May 10, 2016
Summary: 1. Remove note about upgrading Homebrew packages. That was kind of noisy. 2. Use local images instead of those stored on Akamai. 3. Add wording for modifying test project about actually opening a file. 4. Add note about keeping initial defaults for Android Studio install in tact. Tested site locally. Images and new wording appeared as expected. Closes #7477 Reviewed By: vjeux Differential Revision: D3281639 Pulled By: JoelMarcey fbshipit-source-id: ca956d97293ac3793431cb54f3560ee3e52c0dce
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: 1. Remove note about upgrading Homebrew packages. That was kind of noisy. 2. Use local images instead of those stored on Akamai. 3. Add wording for modifying test project about actually opening a file. 4. Add note about keeping initial defaults for Android Studio install in tact. Tested site locally. Images and new wording appeared as expected. Closes facebook#7477 Reviewed By: vjeux Differential Revision: D3281639 Pulled By: JoelMarcey fbshipit-source-id: ca956d97293ac3793431cb54f3560ee3e52c0dce
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: 1. Remove note about upgrading Homebrew packages. That was kind of noisy. 2. Use local images instead of those stored on Akamai. 3. Add wording for modifying test project about actually opening a file. 4. Add note about keeping initial defaults for Android Studio install in tact. Tested site locally. Images and new wording appeared as expected. Closes facebook#7477 Reviewed By: vjeux Differential Revision: D3281639 Pulled By: JoelMarcey fbshipit-source-id: ca956d97293ac3793431cb54f3560ee3e52c0dce
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested site locally. Images and new wording appeared as expected.