RefreshControl refreshing prop and doc improvements #6434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bot plz?!?! :) |
|
@janicduplessis updated the pull request. |
janicduplessis
force-pushed
the
refresh-control-patch-2
branch
from
90ff05d to
c2d4419
Compare
|
@janicduplessis updated the pull request. |
|
@facebook-github-bot shipit |
|
@janicduplessis updated the pull request. |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
|
@janicduplessis updated the pull request. |
1 similar comment
|
@janicduplessis updated the pull request. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
refreshingprop more 'controlled'. Before forgetting to set the refreshing prop in the onRefresh callback would make the js and nativerefreshingprop get out of sync and make the RefreshControl stop refreshing properly (see #5839).I also added a simple usage example and a note about the refreshing prop in the doc.
There was also a small bug in the doc generation code that made the array of color show as [[object Object]] instead of [color] so I fixed that too.
* Test plan*
Tested using the UIExplorer example on iOS and Android. Not setting the
refreshingprop to true in theonRefreshfunction should cause the RefreshControl to stop refreshing immediately and continue working properly after.Closes #5839