Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(update) Install watchman w/ --HEAD to avoid error #630

Merged
merged 1 commit into from
Apr 3, 2015
Merged

(update) Install watchman w/ --HEAD to avoid error #630

merged 1 commit into from
Apr 3, 2015

Conversation

Rudimental
Copy link
Contributor

Updated the docs for installing watchman with --HEAD per @wez suggestion in this issue thread #239

Updated the docs for installing watchman with --HEAD per @wez suggestion in this issue thread #239
@amasad
Copy link
Contributor

amasad commented Apr 3, 2015

We have it in the troubleshooting page. @wez is it long before you update brew recipe?

@wez
Copy link

wez commented Apr 3, 2015

I'll probably submit the PR to brew this weekend (I want to get in a change that will remove a launchd subscription when you watchman shutdown-server) and it will take however long for the brew folks to review and ship.

At that point we should probably suggest that the minimum recommended watchman version to use is 3.1, so maybe we can tweak this PR to indicate that instead of the HEAD install?

@amasad
Copy link
Contributor

amasad commented Apr 3, 2015

Cool, I'll pull this now and hope that master on watchman will continue to be stable until we publish 3.1.

amasad added a commit that referenced this pull request Apr 3, 2015
(update) Install watchman w/ --HEAD to avoid error
@amasad amasad merged commit 08b48ca into facebook:master Apr 3, 2015
@Rudimental
Copy link
Contributor Author

Cool, thanks!

@Rudimental Rudimental deleted the patch-6 branch April 3, 2015 02:17
facebook-github-bot pushed a commit that referenced this pull request Nov 27, 2017
Summary:
If we have a values already set to undefined and set it to undefined again, we invalidate the layout. This change takes this case into account and keeps the layout valid.
Fixes #630
Closes facebook/yoga#648

Differential Revision: D6408013

Pulled By: emilsjolander

fbshipit-source-id: dc2a848d84d3de9f4650fac9e41d7c8169446406
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
Summary:
If we have a values already set to undefined and set it to undefined again, we invalidate the layout. This change takes this case into account and keeps the layout valid.
Fixes facebook#630
Closes facebook/yoga#648

Differential Revision: D6408013

Pulled By: emilsjolander

fbshipit-source-id: dc2a848d84d3de9f4650fac9e41d7c8169446406
bowerman0 pushed a commit to bowerman0/react-native that referenced this pull request Dec 5, 2017
Summary:
If we have a values already set to undefined and set it to undefined again, we invalidate the layout. This change takes this case into account and keeps the layout valid.
Fixes facebook#630
Closes facebook/yoga#648

Differential Revision: D6408013

Pulled By: emilsjolander

fbshipit-source-id: dc2a848d84d3de9f4650fac9e41d7c8169446406
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Oct 14, 2020
… microsoft/react-native-windows (facebook#630)

* Update Podfile.lock

* Move TurboModule/winrt

* Delete entries in RNTester-macOS

* Add podspec

* ...

* ...

* ...

* ...

* ...

* Use the correct podfile

* ...

* Build Succeeded

* ...

* Update RNW.podspec

* ...

* ...

* ...

* Some CocoaPods related fixes (facebook#2)

* [podspec] Fix syntax error

* [podfile] Specify local files using `:path` option

* [podspec] Fix commit hash and source dirname

* ...

* Split -MacOS to -WinRTShared and -WinRTPort

* Fix dependency from RNW to folly

* Finished RNW.podspec

* Remove unnecessary config

* Update Podfile.lock

Co-authored-by: Eloy Durán <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants