Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken image link for EmbeddedAppExample.png #558

Merged
merged 1 commit into from
Apr 1, 2015

Conversation

Za1batsu
Copy link
Contributor

@Za1batsu Za1batsu commented Apr 1, 2015

Image link for EmbeddedAppExample.png failed to load. Fixed link to load original image. Did not touch source code.

screen shot 2015-03-31 at 7 02 28 pm

Image link for EmbeddedAppExample.png failed to load. Fixed link to load original image. Did not touch source code.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@vjeux
Copy link
Contributor

vjeux commented Apr 1, 2015

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Za1batsu
Copy link
Contributor Author

Za1batsu commented Apr 1, 2015

I was referring to the page on GitHub directly.

https://github.com/facebook/react-native/blob/master/docs/EmbeddedApp.md

vjeux added a commit that referenced this pull request Apr 1, 2015
Fixed broken image link for EmbeddedAppExample.png
@vjeux vjeux merged commit 0915e2a into facebook:master Apr 1, 2015
@Za1batsu
Copy link
Contributor Author

Za1batsu commented Apr 1, 2015

@vjeux This change fixed the image problem on GitHub, but have inadvertently broke the one on the official page. Sent and email to your [email protected] regarding this.

@Za1batsu Za1batsu deleted the patch-2 branch April 1, 2015 17:41
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
* add default value to TextInput clearButtonMode description

Small documentation tweak - added information about default value of `clearButtonMode` property to `TextInput` component.

* Update textinput.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants