-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken image link for EmbeddedAppExample.png #558
Conversation
Image link for EmbeddedAppExample.png failed to load. Fixed link to load original image. Did not touch source code.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
I can see the image just fine? http://facebook.github.io/react-native/docs/embeded-app.html#compile-and-run |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I was referring to the page on GitHub directly. https://github.com/facebook/react-native/blob/master/docs/EmbeddedApp.md |
Fixed broken image link for EmbeddedAppExample.png
@vjeux This change fixed the image problem on GitHub, but have inadvertently broke the one on the official page. Sent and email to your [email protected] regarding this. |
Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.4.0...4.5.0) Signed-off-by: dependabot[bot] <[email protected]>
* add default value to TextInput clearButtonMode description Small documentation tweak - added information about default value of `clearButtonMode` property to `TextInput` component. * Update textinput.md
Image link for EmbeddedAppExample.png failed to load. Fixed link to load original image. Did not touch source code.