Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the message shown when bundle download fails #5235

Closed
wants to merge 2 commits into from
Closed

Improve the message shown when bundle download fails #5235

wants to merge 2 commits into from

Conversation

satya164
Copy link
Contributor

screenshot_20160111-004544

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @mhorowitz, @astreet and @foghina to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 10, 2016
@satya164 satya164 changed the title [Not ready] Check if bundle is cached before trying to load Check if bundle is cached before trying to load Jan 10, 2016
@satya164
Copy link
Contributor Author

cc @mkonicek

@satya164 satya164 changed the title Check if bundle is cached before trying to load Check if bundle is cached before trying to execute Jan 10, 2016
@satya164 satya164 changed the title Check if bundle is cached before trying to execute Check if bundle is cached before trying to execute. Fixes #4739 Jan 10, 2016
This was referenced Jan 10, 2016
Closed
Closed
@satya164
Copy link
Contributor Author

Failing tests seem to be unrelated.

@facebook-github-bot
Copy link
Contributor

@satya164 updated the pull request.

@ide
Copy link
Contributor

ide commented Jan 10, 2016

LGTM, will wait for one of the other reviewers though.

astreet
astreet reviewed Jan 11, 2016
View reviewed changes
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerImpl.java
recreateReactContextInBackgroundFromBundleFile();
} else {
mDevSupportManager.showNewJavaError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just throw from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astreet Will do.

@mkonicek
Copy link
Contributor

Thank you so much @satya164! Love the message!

@facebook-github-bot
Copy link
Contributor

@satya164 updated the pull request.

@facebook-github-bot
Copy link
Contributor

@satya164 updated the pull request.

@satya164 satya164 changed the title Check if bundle is cached before trying to execute. Fixes #4739 Improve the message shown when bundle download fails Jan 14, 2016
@satya164
Copy link
Contributor Author

I've changed this PR to only have the error message. Will try to investigate about the bundle execution issue tomorrow. ping @mkonicek @astreet

@facebook-github-bot
Copy link
Contributor

@satya164 updated the pull request.

@foghina
Copy link
Contributor

foghina commented Jan 18, 2016

This looks very useful! The only problem I have with it is that we show the same message internally, where npm start is not a thing. I'm afraid this will confuse people. Perhaps we can just say "ensure that the packager server is running" for the first bullet point? Any other ideas?

@satya164
Copy link
Contributor Author

@foghina Then we don't really help fix the issue IMO. Not sure what to do here :(

@ide
Copy link
Contributor

ide commented Jan 18, 2016

Why don't we ship with @foghina's suggestion? (also +1 to "packager server" instead of "node server") It's still helpful for the error message to explain other potential reasons for not being able to connect to the packager.

@mkonicek
Copy link
Contributor

👍 Agree with @ide! Let's #shipit :)

@facebook-github-bot
Copy link
Contributor

@satya164 updated the pull request.

@satya164
Copy link
Contributor Author

Updated the message. But would certainly prefer to be bit more helpful in the first point.

@foghina
Copy link
Contributor

foghina commented Jan 19, 2016

Yeah, it's a bummer we can't just put the command in there. Let's ship this and see if people are able to figure it out or still run into issues.

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1738347619720175/int_phab to review.

@ghost ghost closed this in 554292d Jan 19, 2016
christopherdro pushed a commit to wildlifela/react-native that referenced this pull request Jan 20, 2016
@satya164 @christopherdro
Improve the message shown when bundle download fails
51ff670 
Summary:
![screenshot_20160111-004544](https://cloud.githubusercontent.com/assets/1174278/12223410/cfc57586-b7fc-11e5-9f38-4d562c6e9f0a.png)
Closes facebook#5235

Reviewed By: svcscm

Differential Revision: D2839867

Pulled By: foghina

fb-gh-sync-id: 36230e1a0d063146db11e9c1d38cea2022a89a12
MattFoley pushed a commit to skillz/react-native that referenced this pull request Jan 21, 2016
@satya164
Improve the message shown when bundle download fails
ac5dfc0 
Summary:
![screenshot_20160111-004544](https://cloud.githubusercontent.com/assets/1174278/12223410/cfc57586-b7fc-11e5-9f38-4d562c6e9f0a.png)
Closes facebook#5235

Reviewed By: svcscm

Differential Revision: D2839867

Pulled By: foghina

fb-gh-sync-id: 36230e1a0d063146db11e9c1d38cea2022a89a12
brentvatne pushed a commit to expo/react-native that referenced this pull request Jan 22, 2016
@satya164 @brentvatne
Improve the message shown when bundle download fails
7efd816 
Summary:
![screenshot_20160111-004544](https://cloud.githubusercontent.com/assets/1174278/12223410/cfc57586-b7fc-11e5-9f38-4d562c6e9f0a.png)
Closes facebook#5235

Reviewed By: svcscm

Differential Revision: D2839867

Pulled By: foghina

fb-gh-sync-id: 36230e1a0d063146db11e9c1d38cea2022a89a12
@satya164 satya164 deleted the dev branch February 2, 2016 16:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@satya164 @facebook-github-bot @ide @mkonicek @foghina @astreet