Added react-native run-ios
#5119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @martinbigio, @mkonicek and @frantic to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@frantic updated the pull request. |
|
This is awesome! +1 to opening xcode as little as possible. |
|
This is awesome! @vjeux and I were talking about this a few days ago :) |
| * Parses the output of `xcrun simctl list devices` command | ||
| */ | ||
| function parseIOSSimulatorsList(text: string): Array<IOSSimulatorInfo> { | ||
| var devices = []; |
|
@frantic updated the pull request. |
|
This is great! 😍 |
|
The implementation looks good to me, @frantic feel free to merge it. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1688959801386516/int_phab to review. |
christopherdro
pushed a commit
to wildlifela/react-native
that referenced
this pull request
Jan 20, 2016
Summary: Works the same way as `react-native run-android`, but targets iOS simulator instead. Under the hood, it uses `xcodebuild` to compile the app and store it in `ios/build` folder, then triggers `instruments` and `simctl` to install and launch the app on simulator. Since Facebook relies on BUCK to build and run iOS app, we probably won't use `run-ios` internally. That's why I'm putting this as public PR instead of internal diff. To test this, I hacked global `react-native` script to install react native from my local checkout instead of from npm, cd into the folder and ran `react-native run-ios`. Closes facebook#5119 Reviewed By: svcscm Differential Revision: D2805199 Pulled By: frantic fb-gh-sync-id: 423a45ba885cb5e48a16ac22095d757d8cca7e37
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Works the same way as `react-native run-android`, but targets iOS simulator instead. Under the hood, it uses `xcodebuild` to compile the app and store it in `ios/build` folder, then triggers `instruments` and `simctl` to install and launch the app on simulator. Since Facebook relies on BUCK to build and run iOS app, we probably won't use `run-ios` internally. That's why I'm putting this as public PR instead of internal diff. To test this, I hacked global `react-native` script to install react native from my local checkout instead of from npm, cd into the folder and ran `react-native run-ios`. Closes facebook/react-native#5119 Reviewed By: svcscm Differential Revision: D2805199 Pulled By: frantic fb-gh-sync-id: 423a45ba885cb5e48a16ac22095d757d8cca7e37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works the same way as
react-native run-android, but targets iOS simulator instead. Under the hood, it usesxcodebuildto compile the app and store it inios/buildfolder, then triggersinstrumentsandsimctlto install and launch the app on simulator.Since Facebook relies on BUCK to build and run iOS app, we probably won't use
run-iosinternally. That's why I'm putting this as public PR instead of internal diff.To test this, I hacked global
react-nativescript to install react native from my local checkout instead of from npm, cd into the folder and ranreact-native run-ios.