[iOS] Setting UIRefreshControl state for ScrollView #5042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
You should take a look at #4915, it provides a cross platform API for UIRefreshControl and PullToRefreshAndroid so this should not be needed. |
|
Closing as duplicate to #4915. Thanks. @janicduplessis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently by setting onRefreshStart callback prop on ScrollView, the user can pull to trigger the refreshing state of the UIRefreshControl, but there's no way to do this programmatically.
This PR add a prop refreshing like PullToRefreshViewAndroid to control the refreshing state. In addition, the endRefreshing callback passed to onRefreshStart is no longer necessary
since it could be stopped by setting refreshing={false}.
I am also wondering if it's possible to provide a unified API to control the refreshing state of ScrollView on both iOS and Android, i.e. by using prop refreshing and callback prop onRefreshStart. The implementation on Android could be wrapping the ScrollView automatically into a SwipeRefreshLayout thus developers don't need to use or care about PullToRefreshViewAndroid (and its underlying SwipeRefreshLayout) in most cases.