[iOS] Fabric: Fixes LayoutConformanceView not work #48253
Conversation
facebook-github-bot
added
CLA Signed
| class LayoutConformanceShadowNode final | ||
| : public ConcreteShadowNode< | ||
| LayoutConformanceShadowNodeComponentName, | ||
| YogaLayoutableShadowNode, | ||
| LayoutConformanceProps> { | ||
| public: | ||
| using ConcreteShadowNode::ConcreteShadowNode; | ||
| }; |
There was a problem hiding this comment.
I don't think this part is required
There was a problem hiding this comment.
@javache Seems this check cannot work if we don't subclass ConcreteShadowNode:
There was a problem hiding this comment.
Oh yeah, interesting. Maybe a different behaviour in compilers.
| class LayoutConformanceShadowNode final | ||
| : public ConcreteShadowNode< | ||
| LayoutConformanceShadowNodeComponentName, | ||
| YogaLayoutableShadowNode, | ||
| LayoutConformanceProps> { | ||
| public: | ||
| using ConcreteShadowNode::ConcreteShadowNode; | ||
| }; |
There was a problem hiding this comment.
Oh yeah, interesting. Maybe a different behaviour in compilers.
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Huge thanks! This seemed to work for internal Buck build of RNTester for iOS, but I think it may do some things behind the scenes I didn't realize. |
|
This pull request was successfully merged by @zhongwuzw in 6076a41 When will my fix make it into a release? | How to file a pick request? |
Summary:
Fixes iOS LayoutConformanceView not work, seems caused by #48188. @NickGerleman can you help to review please?
Changelog:
[IOS] [FIXED] - Fabric: Fixes LayoutConformanceView not work
Test Plan:
Before:
After:
