hook up useNativeViewConfigsInBridgelessMode feature flag #47265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65092536 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 28, 2024
…7265) Summary: Pull Request resolved: facebook#47265 Changelog: [iOS][Breaking] This was originally landed before as part of the effort to coalesce configurations with the feature flag infra, but got reverted due to a build issue. I'm pretty sure it was just because the legacy configuration methods were not cleaned up from the header (RCTConstants.h). I fixed that here. Differential Revision: D65092536
philIip
force-pushed
the
export-D65092536
branch
from
b64d004 to
827a5bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65092536 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65092536 |
philIip
force-pushed
the
export-D65092536
branch
from
827a5bd to
06cac24
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 29, 2024
…7265) Summary: Pull Request resolved: facebook#47265 Changelog: [iOS][Breaking] This was originally landed before as part of the effort to coalesce configurations with the feature flag infra, but got reverted due to a build issue. I'm pretty sure it was just because the legacy configuration methods were not cleaned up from the header (RCTConstants.h). I fixed that here. Reviewed By: javache Differential Revision: D65092536
…7265) Summary: Pull Request resolved: facebook#47265 Changelog: [iOS][Breaking] This was originally landed before as part of the effort to coalesce configurations with the feature flag infra, but got reverted due to a build issue. I'm pretty sure it was just because the legacy configuration methods were not cleaned up from the header (RCTConstants.h). I fixed that here. Reviewed By: javache Differential Revision: D65092536
philIip
force-pushed
the
export-D65092536
branch
from
06cac24 to
aaf113a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65092536 |
|
This pull request has been merged in 6fc500e. |
|
This pull request was successfully merged by @philIip in 6fc500e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Breaking]
This was originally landed before as part of the effort to coalesce configurations with the feature flag infra, but got reverted due to a build issue. I'm pretty sure it was just because the legacy configuration methods were not cleaned up from the header (RCTConstants.h). I fixed that here.
Differential Revision: D65092536