-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'[skip ci] upgrade React Native on a new RDT backend #46669
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Sep 26, 2024
This pull request was exported from Phabricator. Differential Revision: D62967059 |
This pull request was exported from Phabricator. Differential Revision: D62967059 |
hoxyq
force-pushed
the
export-D62967059
branch
from
September 26, 2024 15:21
2e800a7
to
ea645ac
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#46669 # Changelog: [Internal] In React DevTools 6.0.0, settings manager is [no longer used](facebook/react#30986), because the host of the Backend is responsible for settings persistance. Also, `installHook()` call was removed from the top level of the JavaScript module and now we need to call `initialize()` explicitly. The logic for persisting settings will be added in one of the next diffs at the top. Differential Revision: D62967059
This pull request was exported from Phabricator. Differential Revision: D62967059 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#46669 # Changelog: [Internal] In React DevTools 6.0.0, settings manager is [no longer used](facebook/react#30986), because the host of the Backend is responsible for settings persistance. Also, `installHook()` call was removed from the top level of the JavaScript module and now we need to call `initialize()` explicitly. The logic for persisting settings will be added in one of the next diffs at the top. Reviewed By: huntie Differential Revision: D62967059
hoxyq
force-pushed
the
export-D62967059
branch
from
September 26, 2024 17:11
ea645ac
to
8fb6fa0
Compare
Summary: # Changelog: allow-large-files Differential Revision: D63460308
Summary: Changelog: [Internal] - Update `react-native/debugger-frontend` from e8c7943...87b2feb Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](facebookexperimental/rn-chrome-devtools-frontend@e8c7943...87b2feb). Differential Revision: D63455520
Summary: Pull Request resolved: facebook#46669 # Changelog: [Internal] In React DevTools 6.0.0, settings manager is [no longer used](facebook/react#30986), because the host of the Backend is responsible for settings persistance. Also, `installHook()` call was removed from the top level of the JavaScript module and now we need to call `initialize()` explicitly. The logic for persisting settings will be added in one of the next diffs at the top. Reviewed By: huntie Differential Revision: D62967059
This pull request was exported from Phabricator. Differential Revision: D62967059 |
hoxyq
force-pushed
the
export-D62967059
branch
from
September 27, 2024 09:26
8fb6fa0
to
9ad2083
Compare
This pull request has been merged in 53b7f0e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
In React DevTools 6.0.0, settings manager is no longer used, because the host of the Backend is responsible for settings persistance.
Also, call was removed from the top level of the JavaScript module and now we need to call explicitly.
The logic for persisting settings will be added in one of the next diffs at the top.
Differential Revision: D62967059