Mark HoverEvents as handled when pointer event dispatching is enabled #46445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62529586 |
…facebook#46445) Summary: Pull Request resolved: facebook#46445 Similarly to onTouchEvent, we should return true from onHoverEvent to signal to Android that the hover event is "handled" (because we've dispatched the event to JS). This is important to be able to distinguish multiple stacked React roots on top of each other. Changelog: [Android][Fixed] Hover events were dispatched incorrectly when multiple ReactRoots were layered. Reviewed By: mdvacca Differential Revision: D62529586
|
This pull request was exported from Phabricator. Differential Revision: D62529586 |
javache
force-pushed
the
export-D62529586
branch
from
9862b0a to
54a3c0f
Compare
|
This pull request has been merged in 533ef2c. |
|
This pull request was successfully merged by @javache in 533ef2c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Similarly to onTouchEvent, we should return true from onHoverEvent to signal to Android that the hover event is "handled" (because we've dispatched the event to JS). This is important to be able to distinguish multiple stacked React roots on top of each other.
Changelog: [Android][Fixed] Hover events were dispatched incorrectly when multiple ReactRoots were layered.
Reviewed By: mdvacca
Differential Revision: D62529586