-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React-RCTAppDelegate.podspec syntax error for USE_HERMES=1 #46075
Update React-RCTAppDelegate.podspec syntax error for USE_HERMES=1 #46075
Conversation
Hi @rocketraman! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
30ee6b3
to
9986deb
Compare
packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec
Outdated
Show resolved
Hide resolved
packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec
Outdated
Show resolved
Hide resolved
@rocketraman Also please sign the CLA before we can proceed further. |
This is done. |
0467d44
to
8f28fd9
Compare
The `USE_HERMES` flag is set not escaped correctly by `React-RCTAppDelegate.podspec`, and it does not apply. The flag needs to be defined as `USE_HERMES\=1`, but is currently set as `USE_HERMES`. Hopefully this will fix facebook#38193.
8f28fd9
to
44d3db8
Compare
@realsoelynn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@realsoelynn merged this pull request in 143437a. |
This pull request was successfully merged by @rocketraman in 143437a When will my fix make it into a release? | How to file a pick request? |
Summary:
The
USE_HERMES
flag is set not escaped correctly byReact-RCTAppDelegate.podspec
, and it does not apply.The flag needs to be defined as
USE_HERMES\=1
, but is currently set asUSE_HERMES
.Hopefully this will fix #38193.
See #38193 (comment).
Changelog:
Pick one each for the category and type tags:
[IOS] [FIXED] - Fix imports from RCTAppSetupUtils when Hermes is active
Test Plan:
I made the change in my local project and it fixed issues I was having with building my React Native project. See #38193 (comment).