Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] Stub com.facebook.react.settings on 0.74 #45720

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

cortinico
Copy link
Contributor

Summary:

This is a stub of the com.facebook.react.settings plugin.

The plugin got added in 0.75, but to make it easier for 0.74 users to upgrade to 0.75, we're
creating a stub plugin that does nothing. This way, users can include a id("com.facebook.react.settings")
in their settings.gradle file without causing a build failure on 0.74.

This was requested by @gabrieldonadel for Expo templates

Changelog:

[INTERNAL] - Stub com.facebook.react.settings on 0.74

Test Plan:

CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 26, 2024
@analysis-bot
Copy link

analysis-bot commented Jul 26, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,857,508 -3,497,348
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,211,592 -3,338,399
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cortinico cortinico force-pushed the nc/stub-settings-plugin branch 2 times, most recently from 9a56f57 to 22bdfe4 Compare July 26, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants