Fix issue where inset border radius was off when there is a border #45658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60083309 |
|
This pull request was exported from Phabricator. Differential Revision: D60083309 |
joevilches
force-pushed
the
export-D60083309
branch
from
8cb4f98 to
5b3d68c
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jul 25, 2024
…acebook#45658) Summary: Pull Request resolved: facebook#45658 The border radius of the inner "clear region" for inset shadows is based off of the border radius of the padding box path (i.e. the shadow path). Notably, this is not the View's given border radius iff there is a border present. To get this "inner border radius" I added a new method inside of `CSSBackgroundDrawable`. This logic was already present [here](https://www.internalfb.com/code/fbsource/[33e35cbf387a]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java?lines=643-650), so I tried to share most of the code there. There may be a better way to do this, but this seems to be the quickest. Reviewed By: NickGerleman Differential Revision: D60083309
joevilches
force-pushed
the
export-D60083309
branch
from
5b3d68c to
80b3432
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jul 25, 2024
…acebook#45658) Summary: Pull Request resolved: facebook#45658 The border radius of the inner "clear region" for inset shadows is based off of the border radius of the padding box path (i.e. the shadow path). Notably, this is not the View's given border radius iff there is a border present. To get this "inner border radius" I added a new method inside of `CSSBackgroundDrawable`. This logic was already present [here](https://www.internalfb.com/code/fbsource/[33e35cbf387a]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java?lines=643-650), so I tried to share most of the code there. There may be a better way to do this, but this seems to be the quickest. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D60083309
|
This pull request was exported from Phabricator. Differential Revision: D60083309 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D60083309 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jul 25, 2024
…acebook#45658) Summary: Pull Request resolved: facebook#45658 The border radius of the inner "clear region" for inset shadows is based off of the border radius of the padding box path (i.e. the shadow path). Notably, this is not the View's given border radius iff there is a border present. To get this "inner border radius" I added a new method inside of `CSSBackgroundDrawable`. This logic was already present [here](https://www.internalfb.com/code/fbsource/[33e35cbf387a]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java?lines=643-650), so I tried to share most of the code there. There may be a better way to do this, but this seems to be the quickest. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D60083309
joevilches
force-pushed
the
export-D60083309
branch
from
80b3432 to
2688321
Compare
…acebook#45658) Summary: Pull Request resolved: facebook#45658 The border radius of the inner "clear region" for inset shadows is based off of the border radius of the padding box path (i.e. the shadow path). Notably, this is not the View's given border radius iff there is a border present. To get this "inner border radius" I added a new method inside of `CSSBackgroundDrawable`. This logic was already present [here](https://www.internalfb.com/code/fbsource/[33e35cbf387a]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java?lines=643-650), so I tried to share most of the code there. There may be a better way to do this, but this seems to be the quickest. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D60083309
|
This pull request was exported from Phabricator. Differential Revision: D60083309 |
joevilches
force-pushed
the
export-D60083309
branch
from
2688321 to
9bb374b
Compare
|
This pull request has been merged in 8fe3ae3. |
|
This pull request was successfully merged by @joevilches in 8fe3ae3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The border radius of the inner "clear region" for inset shadows is based off of the border radius of the padding box path (i.e. the shadow path). Notably, this is not the View's given border radius iff there is a border present.
To get this "inner border radius" I added a new method inside of
CSSBackgroundDrawable. This logic was already present here, so I tried to share most of the code there. There may be a better way to do this, but this seems to be the quickest.Reviewed By: NickGerleman
Differential Revision: D60083309