Fix jestSupport preprocessor for babel-core location #4542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @cpojer, @none and @voideanvalue to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| @@ -11,6 +11,15 @@ | |||
| const createCacheKeyFunction = require('fbjs-scripts/jest/createCacheKeyFunction'); | |||
| const path = require('path'); | |||
| const transformer = require('../packager/transformer.js'); | |||
| const fs = require('fs'); | |||
|
|
|||
| var babel_core_location = path.join(__dirname, '../node_modules/babel-core/package.json'); | |||
There was a problem hiding this comment.
Can you change this to camel case please?
babelCoreLocation
|
@adrienthiery updated the pull request. |
| try { | ||
| fs.lstatSync(babelCoreLocation); | ||
| } | ||
| catch(e) { |
There was a problem hiding this comment.
nit: move catch to the same line as }
|
@adrienthiery updated the pull request. |
|
@adrienthiery do you have any updates for this pull request? It's been a while so we wanted to check in and see if you've looked at the requested changes. |
|
This appears to have been resolved by a370641. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to fix issue #3999
All feedback appreciated, this is my first Pull request on a big project. :)