Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for BorderRadiusStyle #44964

Closed
wants to merge 1 commit into from
Closed

Add unit tests for BorderRadiusStyle #44964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/ComputedBorderRadius.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@

package com.facebook.react.uimanager.style

/** Represents the collection of possible computed border radius style properties. */
public enum class ComputedBorderRadiusProp {
COMPUTED_BORDER_TOP_LEFT_RADIUS,
COMPUTED_BORDER_TOP_RIGHT_RADIUS,
COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS,
COMPUTED_BORDER_BOTTOM_LEFT_RADIUS,
}

/** Phsysical edge lengths (in DIPs) for a border-radius. */
public data class ComputedBorderRadius(
val topLeft: Float,
Expand All @@ -18,5 +26,14 @@ public data class ComputedBorderRadius(
return topLeft > 0f || topRight > 0f || bottomLeft > 0f || bottomRight > 0f
}

public fun get(property: ComputedBorderRadiusProp): Float {
return when (property) {
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_LEFT_RADIUS -> topLeft
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_RIGHT_RADIUS -> topRight
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_LEFT_RADIUS -> bottomLeft
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS -> bottomRight
}
}

public constructor() : this(0f, 0f, 0f, 0f)
}
186 changes: 186 additions & 0 deletions ...t-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/BorderRadiusStyleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

package com.facebook.react.uimanager

import android.content.Context
import com.facebook.react.uimanager.style.BorderRadiusProp
import com.facebook.react.uimanager.style.BorderRadiusStyle
import com.facebook.react.uimanager.style.ComputedBorderRadiusProp
import org.assertj.core.api.Assertions.*
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment

/** Tests for [BorderRadiusStyle] */
@RunWith(RobolectricTestRunner::class)
class BorderRadiusStyleTest {

private val ctx: Context = RuntimeEnvironment.getApplication()

@Test
fun testCorrectPriorityLTR() {
val propertyOrderMap =
mapOf(
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_LEFT_RADIUS,
BorderRadiusProp.BORDER_TOP_START_RADIUS,
BorderRadiusProp.BORDER_START_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_RIGHT_RADIUS,
BorderRadiusProp.BORDER_TOP_END_RADIUS,
BorderRadiusProp.BORDER_END_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_LEFT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_START_RADIUS,
BorderRadiusProp.BORDER_START_END_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_RIGHT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_END_RADIUS,
BorderRadiusProp.BORDER_END_END_RADIUS),
)

propertyOrderMap.forEach { order ->
val borderRadiusStyle = BorderRadiusStyle()
// Starting count on 3 to test 0 override
var count = 3f
for (prop in order.value) {
borderRadiusStyle.set(prop, LengthPercentage(count, LengthPercentageType.POINT))
val resolved = borderRadiusStyle.resolve(0, context = ctx, width = 100f, height = 100f)
assertThat(resolved.get(order.key)).isEqualTo(count)
count -= 1f
}
}
}

@Test
fun testCorrectPriorityRTL() {
setContextLeftAndRightSwap(ctx, true)
val propertyOrderMap =
mapOf(
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_RIGHT_RADIUS,
BorderRadiusProp.BORDER_TOP_END_RADIUS,
BorderRadiusProp.BORDER_END_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_LEFT_RADIUS,
BorderRadiusProp.BORDER_TOP_START_RADIUS,
BorderRadiusProp.BORDER_START_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_RIGHT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_START_RADIUS,
BorderRadiusProp.BORDER_END_END_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_LEFT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_END_RADIUS,
BorderRadiusProp.BORDER_START_END_RADIUS),
)

propertyOrderMap.forEach { order ->
val borderRadiusStyle = BorderRadiusStyle()
// Starting count on 3 to test 0 override
var count = 3f
for (prop in order.value) {
borderRadiusStyle.set(prop, LengthPercentage(count, LengthPercentageType.POINT))
val resolved = borderRadiusStyle.resolve(1, context = ctx, width = 100f, height = 100f)
assertThat(resolved.get(order.key)).isEqualTo(count)
count -= 1f
}
}
}

@Test
fun testCorrectPriorityRTLNoSwap() {
setContextLeftAndRightSwap(ctx, false)
val propertyOrderMap =
mapOf(
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_LEFT_RADIUS,
BorderRadiusProp.BORDER_TOP_END_RADIUS,
BorderRadiusProp.BORDER_END_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_TOP_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_TOP_RIGHT_RADIUS,
BorderRadiusProp.BORDER_TOP_START_RADIUS,
BorderRadiusProp.BORDER_START_START_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_LEFT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_LEFT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_START_RADIUS,
BorderRadiusProp.BORDER_END_END_RADIUS),
ComputedBorderRadiusProp.COMPUTED_BORDER_BOTTOM_RIGHT_RADIUS to
arrayOf(
BorderRadiusProp.BORDER_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_RIGHT_RADIUS,
BorderRadiusProp.BORDER_BOTTOM_END_RADIUS,
BorderRadiusProp.BORDER_START_END_RADIUS),
)

propertyOrderMap.forEach { order ->
val borderRadiusStyle = BorderRadiusStyle()
// Starting count on 3 to test 0 override
var count = 3f
for (prop in order.value) {
borderRadiusStyle.set(prop, LengthPercentage(count, LengthPercentageType.POINT))
val resolved = borderRadiusStyle.resolve(1, context = ctx, width = 100f, height = 100f)
assertThat(resolved.get(order.key)).isEqualTo(count)
count -= 1f
}
}
}

@Test
fun testBorderRadiusPercentages() {
val borderRadiusStyle =
BorderRadiusStyle(
topLeft = LengthPercentage(0f, LengthPercentageType.PERCENT),
topRight = LengthPercentage(10f, LengthPercentageType.PERCENT),
bottomLeft = LengthPercentage(20f, LengthPercentageType.PERCENT),
bottomRight = LengthPercentage(30f, LengthPercentageType.PERCENT),
)
val resolved = borderRadiusStyle.resolve(0, context = ctx, width = 1000f, height = 1000f)

assertThat(resolved.topLeft).isEqualTo(0f)
assertThat(resolved.topRight).isEqualTo(100f)
assertThat(resolved.bottomLeft).isEqualTo(200f)
assertThat(resolved.bottomRight).isEqualTo(300f)
}

/*
* Make I18nUtil.instance.doLeftAndRightSwapInRTL(context) return false
* by setting context preference
*/
private fun setContextLeftAndRightSwap(context: Context, leftAndRightSwap: Boolean) {
val sharedPrefs =
context.getSharedPreferences(
"com.facebook.react.modules.i18nmanager.I18nUtil", Context.MODE_PRIVATE)
val editor = sharedPrefs.edit()
editor.putBoolean("RCTI18nUtil_makeRTLFlipLeftAndRightStyles", leftAndRightSwap)
editor.apply()
}
}