Back out "chore(dev-middleware): add localhost as default host in start command config"
#44800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58192651 |
…start` command config" (facebook#44800) Summary: This is a revert of facebook#44244, as we've observed [breaking behaviour](facebook#44244 (comment)) where Android emulators could not connect to the dev server with default settings. The team doesn't have bandwidth/prio to figure this out with the default `host` value just now, so we are reverting. Changelog: [Internal] (Nullifies c402dcf) Reviewed By: cipolleschi Differential Revision: D58192651
|
This pull request was exported from Phabricator. Differential Revision: D58192651 |
|
cc @szymonrybczak — apologies! |
|
This pull request has been merged in a569c82. |
|
This pull request was successfully merged by @huntie in a569c82. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…start` command config" (facebook#44800) Summary: Pull Request resolved: facebook#44800 This is a revert of facebook#44244, as we've observed [breaking behaviour](facebook#44244 (comment)) where Android emulators could not connect to the dev server with default settings. The team doesn't have bandwidth/prio to figure this out with the default `host` value just now, so we are reverting. Changelog: [Internal] (Nullifies c402dcf) Reviewed By: cipolleschi Differential Revision: D58192651 fbshipit-source-id: dd2183d6baa6499ab59e21365adfe62e7a786dfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a revert of #44244, as we've observed breaking behaviour where Android emulators could not connect to the dev server with default settings.
The team doesn't have bandwidth/prio to figure this out with the default
hostvalue just now, so we are reverting.Changelog: [Internal] (Nullifies c402dcf)
Differential Revision: D58192651