Fixup margin: auto and justification behavior for overflowed containers #44069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56091577 |
Base commit: fe9942a |
…rs (facebook#44069) Summary: X-link: facebook/yoga#1646 Fixes facebook/yoga#978 1. Don't allow auto margin spaces to become a negative length 2. Replicate fallback alignment behavior specified by box-alignment spec that we are using for align-content. Reviewed By: joevilches Differential Revision: D56091577
NickGerleman
force-pushed
the
export-D56091577
branch
from
5baf25d
to
30bf453
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 17, 2024
…rs (facebook#1646) Summary: X-link: facebook/react-native#44069 Fixes facebook#978 1. Don't allow auto margin spaces to become a negative length 2. Replicate fallback alignment behavior specified by box-alignment spec that we are using for align-content. Reviewed By: joevilches Differential Revision: D56091577
|
This pull request was exported from Phabricator. Differential Revision: D56091577 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 18, 2024
Summary: X-link: facebook/yoga#1646 X-link: facebook/react-native#44069 Fixes facebook/yoga#978 1. Don't allow auto margin spaces to become a negative length 2. Replicate fallback alignment behavior specified by box-alignment spec that we are using for align-content. Reviewed By: joevilches Differential Revision: D56091577 fbshipit-source-id: 3c02f81f969bb947cdc5c80b15faaa0b0d39c0c2
|
This pull request has been merged in f21d9af. |
|
This pull request was successfully merged by @NickGerleman in f21d9af. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 18, 2024
…rs (#1646) Summary: Pull Request resolved: #1646 X-link: facebook/react-native#44069 Fixes #978 1. Don't allow auto margin spaces to become a negative length 2. Replicate fallback alignment behavior specified by box-alignment spec that we are using for align-content. Reviewed By: joevilches Differential Revision: D56091577 fbshipit-source-id: 3c02f81f969bb947cdc5c80b15faaa0b0d39c0c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes facebook/yoga#978
Differential Revision: D56091577