Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert views/image interface files #43742

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Apr 1, 2024

Summary:

Changelog:

[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: D55589946

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55589946

@analysis-bot
Copy link

analysis-bot commented Apr 1, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,217,878 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,594,633 -3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b52c7aa
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55589946

rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Reviewed By: tdn120

Differential Revision: D55589946
@rshest rshest force-pushed the export-D55589946 branch from c41ba8c to e2eef80 Compare April 8, 2024 08:21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55589946

rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Reviewed By: tdn120

Differential Revision: D55589946
@rshest rshest force-pushed the export-D55589946 branch from e2eef80 to 53dab0c Compare April 8, 2024 09:26
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Reviewed By: tdn120

Differential Revision: D55589946
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55589946

@rshest rshest force-pushed the export-D55589946 branch from 53dab0c to d8ce76a Compare April 8, 2024 09:40
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
rshest added a commit to rshest/react-native that referenced this pull request Apr 8, 2024
Summary:
Pull Request resolved: facebook#43742

## Changelog:
[Internal] -

As in the title - taking a subset of the views/image Java files, those that are related to interfaces, and convert them to Kotlin.

Differential Revision: https://internalfb.com/D55589946
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b069fca.

Copy link

github-actions bot commented Apr 8, 2024

This pull request was successfully merged by @rshest in b069fca.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants