Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DevSettings related code to Kotlin #43731

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Mar 31, 2024

Summary:

Changelog:

[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 31, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

@rshest rshest force-pushed the export-D55574529 branch from 3b4090d to 7f3b8b5 Compare March 31, 2024 22:54
rshest added a commit to rshest/react-native that referenced this pull request Mar 31, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

@rshest rshest force-pushed the export-D55574529 branch from 7f3b8b5 to 86aeb4e Compare March 31, 2024 23:18
rshest added a commit to rshest/react-native that referenced this pull request Mar 31, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
rshest added a commit to rshest/react-native that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: https://internalfb.com/D55574529
rshest added a commit to rshest/react-native that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: https://internalfb.com/D55574529
rshest added a commit to rshest/react-native that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: https://internalfb.com/D55574529
rshest added a commit to rshest/react-native that referenced this pull request Apr 1, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: https://internalfb.com/D55574529
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

@rshest rshest force-pushed the export-D55574529 branch from 86aeb4e to a420d10 Compare April 2, 2024 10:59
rshest added a commit to rshest/react-native that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

rshest added a commit to rshest/react-native that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
@rshest rshest force-pushed the export-D55574529 branch from a420d10 to 8c05bc9 Compare April 2, 2024 11:58
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

rshest added a commit to rshest/react-native that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
@rshest rshest force-pushed the export-D55574529 branch from 8c05bc9 to b3cfdfd Compare April 2, 2024 12:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

rshest added a commit to rshest/react-native that referenced this pull request Apr 2, 2024
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Differential Revision: D55574529
@rshest rshest force-pushed the export-D55574529 branch from b3cfdfd to ea72528 Compare April 2, 2024 12:27
Summary:
Pull Request resolved: facebook#43731

# Changelog:
[Internal] -

Converts code related to DevSettings Module/Activity to Kotlin.

Reviewed By: cortinico

Differential Revision: D55574529
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55574529

@rshest rshest force-pushed the export-D55574529 branch from ea72528 to f9afeda Compare April 8, 2024 08:21
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,217,875 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,594,629 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b52c7aa
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a977b2e.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This pull request was successfully merged by @rshest in a977b2e.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants