Avoid global_ref to javaPart in TurboModuleManager #43613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55241235 |
|
This pull request was exported from Phabricator. Differential Revision: D55241235 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 22, 2024
Summary: Pull Request resolved: facebook#43613 Storing a global_ref to `jThis` in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. We can replace the reference in this class by using the this pointer passed in when `installJSIBindings` is invoked. Changelog: [Internal] Differential Revision: D55241235
javache
force-pushed
the
export-D55241235
branch
from
84d0c2e to
826d2c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55241235 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 22, 2024
Summary: Pull Request resolved: facebook#43613 Storing a global_ref to `jThis` in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. We can replace the reference in this class by using the this pointer passed in when `installJSIBindings` is invoked. Changelog: [Internal] Differential Revision: D55241235
javache
force-pushed
the
export-D55241235
branch
from
826d2c6 to
b6b7204
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 22, 2024
Summary: Pull Request resolved: facebook#43613 Storing a global_ref to `jThis` in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. We can replace the reference in this class by using the this pointer passed in when `installJSIBindings` is invoked. Changelog: [Internal] Differential Revision: D55241235
|
This pull request was exported from Phabricator. Differential Revision: D55241235 |
javache
force-pushed
the
export-D55241235
branch
from
b6b7204 to
3d4ed66
Compare
Differential Revision: D55240490
Differential Revision: D55241234
Differential Revision: D55241232
Differential Revision: D55241233
Summary: Pull Request resolved: facebook#43613 Storing a global_ref to `jThis` in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. We can replace the reference in this class by using the this pointer passed in when `installJSIBindings` is invoked. Changelog: [Internal] Differential Revision: D55241235
javache
force-pushed
the
export-D55241235
branch
from
3d4ed66 to
24c94b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55241235 |
|
This pull request has been merged in 12d22e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Storing a global_ref to
jThisin a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa.We can replace the reference in this class by using the this pointer passed in when
installJSIBindingsis invoked.Changelog: [Internal]
Differential Revision: D55241235