Fix retain cycle in ComponentNameResolverManager #43611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55240490 |
javache
force-pushed
the
export-D55240490
branch
from
42c73f3 to
183e4dc
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 22, 2024
Summary: Storing a global_ref to `jThis` in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. In this class, we didn't seem to need this reference anyway. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D55240490
|
This pull request was exported from Phabricator. Differential Revision: D55240490 |
…nager (facebook#43611) Summary: Pull Request resolved: facebook#43611 Storing a global_ref to in a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa. In this class, we didn'\''t seem to need this reference anyway. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D55240490
|
This pull request was exported from Phabricator. Differential Revision: D55240490 |
javache
force-pushed
the
export-D55240490
branch
from
183e4dc to
fe1541b
Compare
|
This pull request has been merged in ee3d5f5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Storing a global_ref to
jThisin a JNI hybrid object leads to a reference cycle which cannot be cleaned up by Java GC. The Java object will keep the C++ object alive and vice versa.In this class, we didn't seem to need this reference anyway.
Changelog: [Internal]
Differential Revision: D55240490