TurboModule::emitDeviceEvent doesn't require jsi::Runtime argument anymore #43376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 7, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 7, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 7, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 7, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 7, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 8, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 8, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
Base commit: 9b1c486 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 8, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 8, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 8, 2024
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
…book#43375) Summary: ## Changelog: [Internal] - As discussed with the team, it makes more sense to pass the reference to the correct `jsi::Runtime` object as an argument to the ` CallInvoker::invoke*` callbacks, that are provided by the user. There are various use cases when user would like to get a hold of the `jsi::Runtime` in the callback, and it makes sense, since it is guaranteed to run on the JS thread. So far people have been coming up with all kinds of workarounds for that, none of them safe enough. Reviewed By: rubennorte Differential Revision: D54643171
…ymore (facebook#43376) Summary: ## Changelog: [Internal] - Make it possible to call `emitDeviceEvent` from C++ TurboModules without the need to explicitly provide the reference to `jsi::Runtime`, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of. Reviewed By: rubennorte Differential Revision: D54643903
|
This pull request was exported from Phabricator. Differential Revision: D54643903 |
|
This pull request has been merged in 6c28c87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
Make it possible to call
emitDeviceEventfrom C++ TurboModules without the need to explicitly provide the reference tojsi::Runtime, as in some contexts (when we call e.g. not from the JS thread itself) it may be hard to get hold of.Differential Revision: D54643903