-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): fix ndkVersion
is unset when building from source
#43131
Conversation
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 7fffe69 |
@cortinico merged this pull request in a1171f7. |
@cortinico do we need to get this in the 73/74 branches? we only build nightlies from sources so for us in main should be enough, but not sure if it might be needed elsewhere |
Nope I don't think we do unless we got reports of specific failures on a given version |
…3131) Summary: `ndkVersion` is unset when building from source using this guide: https://reactnative.dev/contributing/how-to-build-from-source ## Changelog: [ANDROID] [FIXED] - Fix `ndkVersion` is unset when building from source Pull Request resolved: #43131 Test Plan: ``` git clone https://github.com/microsoft/react-native-test-app.git cd react-native-test-app npm run set-react-version nightly yarn # Manually apply the patch in node_modules/react-native/ReactAndroid/build.gradle.kts # Enable building from source sed -i '' 's/#react.buildFromSource/react.buildFromSource/' example/android/gradle.properties # Build cd example/android ./gradlew assembleDebug ``` Reviewed By: christophpurrer Differential Revision: D54006425 Pulled By: cortinico fbshipit-source-id: 9ede64bc14af4cf609b7a4c12c5a1082bbc31f09
* fix(android): fix `ndkVersion` is unset when building from source (#43131) Summary: `ndkVersion` is unset when building from source using this guide: https://reactnative.dev/contributing/how-to-build-from-source ## Changelog: [ANDROID] [FIXED] - Fix `ndkVersion` is unset when building from source Pull Request resolved: #43131 Test Plan: ``` git clone https://github.com/microsoft/react-native-test-app.git cd react-native-test-app npm run set-react-version nightly yarn # Manually apply the patch in node_modules/react-native/ReactAndroid/build.gradle.kts # Enable building from source sed -i '' 's/#react.buildFromSource/react.buildFromSource/' example/android/gradle.properties # Build cd example/android ./gradlew assembleDebug ``` Reviewed By: christophpurrer Differential Revision: D54006425 Pulled By: cortinico fbshipit-source-id: 9ede64bc14af4cf609b7a4c12c5a1082bbc31f09 * Fix build from source for hermes-engine (#43609) Summary: Pull Request resolved: #43609 When users are building from source for React Native they don't have an ndkVersion variable specified. So we want to fallback to the global NDK version we set for the whole build here. Changelog: [Android] [Fixed] - Fix build from source for hermes-engine Reviewed By: dmytrorykun Differential Revision: D55240603 fbshipit-source-id: 3c725a164b40e176548af8ada9fcb13d391ef017 --------- Co-authored-by: Tommy Nguyen <[email protected]>
Summary:
ndkVersion
is unset when building from source using this guide: https://reactnative.dev/contributing/how-to-build-from-sourceChangelog:
[ANDROID] [FIXED] - Fix
ndkVersion
is unset when building from sourceTest Plan: