Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang warning for -Winconsistent-missing-destructor-override #42942

Closed
wants to merge 1 commit into from
Closed

Fix clang warning for -Winconsistent-missing-destructor-override #42942

wants to merge 1 commit into from

Commits on Feb 9, 2024

  1. Fix clang warning for -Winconsistent-missing-destructor-override (fac… 

    …ebook#42942)

Summary:

Instance derives from jsinspector_modern::InstanceTargetDelegate, which defines a virtual destructor, but Instance does not mark its destructor with override.

## Changelog [Internal]

Differential Revision: D53609922
    @rozele @facebook-github-bot
    rozele authored and facebook-github-bot committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    19d4b20 View commit details
    Browse the repository at this point in the history