Kotlin to 1.9.22 #42927
Closed
Kotlin to 1.9.22 #42927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
force-pushed
the
export-D53576844
branch
from
f0bc23a to
1fae565
Compare
Summary: This bumps Kotlin to 1.9.22 which is the latest in OSS and closer to the version we use inside fbsource. Turns out that Explicit API mode was not enabled correctly, so I had to go over all the Kotlin classes and correctly set them to `public` if they were intended to be for public consumption. I updated some of them to `private` or `internal` but otherwise I've defaulted to `public` which is the default we have right now. Changelog: [Android] [Changed] - Kotlin to 1.9.22 Reviewed By: cipolleschi Differential Revision: D53576844 fbshipit-source-id: f0d31daf1866259d88fb5be88824d8470af6ae98
|
This pull request was exported from Phabricator. Differential Revision: D53576844 |
cortinico
force-pushed
the
export-D53576844
branch
from
1fae565 to
1df9414
Compare
|
This pull request has been merged in 3c2b2b1. |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#42927 This bumps Kotlin to 1.9.22 which is the latest in OSS and closer to the version we use inside fbsource. Turns out that Explicit API mode was not enabled correctly, so I had to go over all the Kotlin classes and correctly set them to `public` if they were intended to be for public consumption. I updated some of them to `private` or `internal` but otherwise I've defaulted to `public` which is the default we have right now. Changelog: [Android] [Changed] - Kotlin to 1.9.22 Reviewed By: cipolleschi Differential Revision: D53576844 fbshipit-source-id: dd8b08ce9bf87f738159f60fd850e3e3bc490ebc Original: facebook/react-native@3c2b2b1
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#42927 This bumps Kotlin to 1.9.22 which is the latest in OSS and closer to the version we use inside fbsource. Turns out that Explicit API mode was not enabled correctly, so I had to go over all the Kotlin classes and correctly set them to `public` if they were intended to be for public consumption. I updated some of them to `private` or `internal` but otherwise I've defaulted to `public` which is the default we have right now. Changelog: [Android] [Changed] - Kotlin to 1.9.22 Reviewed By: cipolleschi Differential Revision: D53576844 fbshipit-source-id: dd8b08ce9bf87f738159f60fd850e3e3bc490ebc Original-Commit: facebook/react-native@3c2b2b1
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#42927 This bumps Kotlin to 1.9.22 which is the latest in OSS and closer to the version we use inside fbsource. Turns out that Explicit API mode was not enabled correctly, so I had to go over all the Kotlin classes and correctly set them to `public` if they were intended to be for public consumption. I updated some of them to `private` or `internal` but otherwise I've defaulted to `public` which is the default we have right now. Changelog: [Android] [Changed] - Kotlin to 1.9.22 Reviewed By: cipolleschi Differential Revision: D53576844 fbshipit-source-id: dd8b08ce9bf87f738159f60fd850e3e3bc490ebc Original-Commit: facebook/react-native@3c2b2b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This bumps Kotlin to 1.9.22 which is the latest in OSS and closer to the version we use inside fbsource.
Turns out that Explicit API mode was not enabled correctly, so I had to go over all the Kotlin classes
and correctly set them to
publicif they were intended to be for public consumption.I updated some of them to
privateorinternalbut otherwise I've defaulted topublicwhich is the defaultwe have right now.
Changelog:
[Android] [Changed] - Kotlin to 1.9.22
Differential Revision: D53576844