Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Releases] Fixset-version to also update packages/react-native source #42897

Closed
wants to merge 1 commit into from

Conversation

lunaleaps
Copy link
Contributor

@lunaleaps lunaleaps commented Feb 6, 2024

Summary:
Changelog: [Internal] - Update nightly flow to use set-version

This change fixes set-version to update the packages/react-native native source and build files (as set-rn-version does) -- this was an oversight but not an issue as set-version isn't actually used anywhere right now.

Differential Revision: D53463414

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

@analysis-bot
Copy link

analysis-bot commented Feb 6, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,238,152 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,589 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cadaf26
Branch: main

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 6, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 6, 2024
…rce (facebook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Differential Revision: D53463414
@lunaleaps lunaleaps changed the title Use set-version in nightly publishes [Releases] Fixset-version to also update packages/react-native source Feb 6, 2024
lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 9, 2024
…rce (facebook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 10, 2024
…rce (facebook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
lunaleaps added a commit to lunaleaps/react-native that referenced this pull request Feb 10, 2024
…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

…ook#42897)

Summary:

Changelog: [Internal] - Update nightly flow to use set-version

This change fixes `set-version` to update the `packages/react-native` native source and build files (as `set-rn-version` does) -- this was an oversight but not an issue as `set-version` isn't actually used anywhere right now.

Reviewed By: huntie

Differential Revision: D53463414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53463414

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 68e6a94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants