Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Button to ESM #42796

Closed
wants to merge 3 commits into from

Conversation

fabriziocucci
Copy link
Contributor

Summary:
As per title.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D53308084

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53308084

Summary:

As mentioned also in D53307738, `generate-docs` doesn't seem to be used.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D53308808
Summary:

As per title.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D53308758
Summary:

As per title.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D53308084
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53308084

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,197,461 -213
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,576,218 -87
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 107f2f9
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ac43ee1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants