feat(iOS): add support for missing text content types #42788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
javache
requested changes
Feb 1, 2024
packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm
Outdated
Show resolved
Hide resolved
krozniata
changed the title
|
Hey @javache, I've updated this PR according to your suggestions, is there anything that needs to be done to get it merged? |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
react-native-bot
removed
the
Stale
cipolleschi
approved these changes
Aug 20, 2024
|
Can you also rebase on top of master? I can't see the GitHub Actions running |
krozniata
force-pushed
the
feat/missing-ios-text-content-types
branch
from
0dc0220
to
f515fd7
Compare
|
rebased 👌
|
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 22, 2024
Summary: This PR adds few missing text content types on iOS (available from iOS 15) - dateTime - flightNumber - shipmentTrackingNumber ## Changelog: [IOS] [ADDED] - Add support for missing text content types Pull Request resolved: facebook#42788 Test Plan: Make sure that `RNTester` builds and runs successfully Differential Revision: D61656748
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Aug 22, 2024
Summary: This PR adds few missing text content types on iOS (available from iOS 15) - dateTime - flightNumber - shipmentTrackingNumber ## Changelog: [IOS] [ADDED] - Add support for missing text content types Pull Request resolved: facebook#42788 Test Plan: Make sure that `RNTester` builds and runs successfully Differential Revision: D61656748
|
@cipolleschi merged this pull request in d7a3e48. |
|
This pull request was successfully merged by @krozniata in d7a3e48 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds few missing text content types on iOS (available from iOS 15)
Changelog:
[IOS] [ADDED] - Add support for missing text content types
Test Plan:
Make sure that
RNTesterbuilds and runs successfully