Mark CallInvokerHolder APIs as FrameworkAPI only #42399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52913739 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Mark CallInvokerHolder APIs as FrameworkAPI only, these APIs are meant to be used only for partner frameworks changelog: [internal] internal Reviewed By: cortinico Differential Revision: D52913739
mdvacca
force-pushed
the
export-D52913739
branch
from
ec4fe2a to
78326b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52913739 |
Base commit: 461edd2 |
Summary: Mark CallInvokerHolder APIs as FrameworkAPI only, these APIs are meant to be used only for partner frameworks changelog: [internal] internal Reviewed By: cortinico Differential Revision: D52913739
mdvacca
force-pushed
the
export-D52913739
branch
from
78326b6 to
04fa812
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52913739 |
|
This pull request has been merged in 6fbf042. |
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jan 22, 2024
…1-a58ec074b (#26587) # Why react-native nightlies testing is broken on 0.74.0-nightly-20240121-a58ec074b # How - [core] CallInvokerHolderImpl requires a framework api: facebook/react-native#42399 - [lottie-react-native] breaking change discussed at: facebook/react-native#39630 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mark CallInvokerHolder APIs as FrameworkAPI only, these APIs are meant to be used only for partner frameworks
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D52913739