Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format package.json files in the monorepo #42256

Closed
wants to merge 1 commit into from

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Jan 12, 2024

Summary:

Over in React Native macOS land, I opened microsoft#2030 to update our mono repo to use Yarn 4. As a side effect, all the package.json files are formatted after running yarn install. So that React Native macOS doesn't maintain this diff (and because they should only be good / no harm), let's upstream the formatting changes.

Changelog:

[INTERNAL] [CHANGED] - Format package.json files in the monorepo

Test Plan:

This change should be a no-op, CI should pass.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2024
@facebook-github-bot facebook-github-bot added p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 12, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,791,333 +7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,186,631 +21
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9bd357e
Branch: main

@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Saadnajmi
Copy link
Contributor Author

Just double checking, any issues with this PR? It helps me decide whether or not it worth's maintaining the diff in React Native macOS is why I ask :)

@huntie
Copy link
Member

huntie commented Jan 19, 2024

@Saadnajmi Internal infra checks have been a bit sticky! I'll retry soon.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 22, 2024
@facebook-github-bot
Copy link
Contributor

@huntie merged this pull request in 6d77d7b.

@Saadnajmi Saadnajmi deleted the yarn4-rn branch January 23, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants