Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbol not found _jump_fcontext with use_frameworks! #42230

Closed
wants to merge 1 commit into from
Closed

Fix symbol not found _jump_fcontext with use_frameworks! #42230

wants to merge 1 commit into from

Commits on Jan 11, 2024

  1. Fix symbol not found _jump_fcontext with use_frameworks! (facebook#42230 

    )

Summary:

While developing Xcode 15, Apple reimplemented the linker.
In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15.

To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker.

In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore.
But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup.

This change remove the flags if the Xcode that is used is 15.1 or greater.

*Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native.

This Fixes facebook#39945

## Changelog:
[Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater.

Reviewed By: cortinico

Differential Revision: D52658197
    @cipolleschi @facebook-github-bot
    cipolleschi authored and facebook-github-bot committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8848c0d View commit details
    Browse the repository at this point in the history