Bump CLI to 13.5.1

[szymonrybczak]

Summary:

Updates CLI to v13.5.1.

Changelog:

[GENERAL] [CHANGED] - Bump CLI to 13.5.1

Test Plan:

CI

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,951,051	-767
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,334,831	-761
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: cbd818d
Branch: main

[szymonrybczak]

cc @huntie I've updated the PR with the newest version, mind looking again? 🙏

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[huntie]

@szymonrybczak Looks like the Yarn v3 breaking change is impacting our test_<platform>_template scripts in CircleCI.

• feat: use Yarn v3 with nodeLinker: node-modules for new projects react-native-community/cli#2134

Can you look at the changes to our CI scripts needed to support this?

cc @lunaleaps @fortmarek @cortinico @cipolleschi This may impact the yarn test-e2e-local script.
cc @motiz88 @robhogan For significant JS infra change.

[szymonrybczak]

One of the breaking changes of Yarn v3 was that immutable installs on CI were enabled by default, meaning when there's a new yarn.lock file generated or there's a change in yarn.lock file it throws an error. When generating new project in test_<platform>_template it needs to create a yarn.lock so to workaround this error we need to set a YARN_ENABLE_IMMUTABLE_INSTALLS=false environment variable.

cc @lunaleaps @fortmarek @cortinico @cipolleschi This may impact the yarn test-e2e-local script.

This error only applies in CI environments.

[szymonrybczak]

I see that after adding YARN_ENABLE_IMMUTABLE_INSTALLS=false to relevant jobs, project is properly created. But Android and iOS is not successfully building. I'm not sure is this change related to this fail 🤔 cc: @cipolleschi @cortinico do you have maybe any ideas why builds are failing?

[cortinico]

@szymonrybczak the Android CI is failing because Verdaccio is not working properly (not sure why, but needs investigation). Practically what is happening is that we're pulling @react-native/[email protected] from NPM (this one https://www.npmjs.com/package/@react-native/gradle-plugin/v/0.74.0) rather than the one from Verdaccio.

If you SSH inside the worker you'll see this:

$ yarn why @react-native/gradle-plugin
├─ react-native@file:/root/react-native/build/react-native-1000.0.0-fbaad3dff.tgz::locator=AndroidTemplateProject%40workspace%3A.
│  └─ @react-native/gradle-plugin@npm:0.74.0 (via npm:0.74.0)
│
└─ react-native@file:/root/react-native/build/react-native-1000.0.0-fbaad3dff.tgz::locator=AndroidTemplateProject%40workspace%3A. [9bad8]
   └─ @react-native/gradle-plugin@npm:0.74.0 (via npm:0.74.0)

So it seems like with this change we're not accounting for Verdaccio anymore causing the CI to fail

[szymonrybczak]

@cortinico ah I see, thanks for checking this! So actually to make Yarn v3 working with local server, and to make it properly download packages from that server we need to pass the server destination in .yarnrc.yml file. I've created an option to pass custom config when initialising project with React Native Community CLI: react-native-community/cli#2273.

[szymonrybczak]

After setting npmRegistryServer and unsafeHttpWhitelist before installing packages, all tests are passing!

[facebook-github-bot]

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@huntie merged this pull request in 78967b3.