Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the "platform" option to generate-codegen-artifacts.js #42012

Closed
wants to merge 1 commit into from

Conversation

dmytrorykun
Copy link
Contributor

Summary:
Up until now generate-codegen-artifacts.js has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Differential Revision: D52257542

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52257542

@analysis-bot
Copy link

analysis-bot commented Dec 20, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,577,360 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,950,206 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4885743
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52257542

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 20, 2023
…ebook#42012)

Summary:

Up until now `generate-codegen-artifacts.js` has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Reviewed By: RSNara

Differential Revision: D52257542
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52257542

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 21, 2023
…ebook#42012)

Summary:

Up until now `generate-codegen-artifacts.js` has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Reviewed By: RSNara

Differential Revision: D52257542
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Dec 21, 2023
…ebook#42012)

Summary:

Up until now `generate-codegen-artifacts.js` has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Reviewed By: RSNara

Differential Revision: D52257542
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52257542

…ebook#42012)

Summary:

Up until now `generate-codegen-artifacts.js` has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Reviewed By: RSNara

Differential Revision: D52257542
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52257542

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7b10609.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…ebook#42012)

Summary:
Pull Request resolved: facebook#42012

Up until now `generate-codegen-artifacts.js` has been iOS only. But its logic is actually quite general, and this diff makes it platform agnostic.

Changelog: [General][Added] - Introduce the "platform" option to generate-codegen-artifacts.js

Reviewed By: RSNara

Differential Revision: D52257542

fbshipit-source-id: b7e698c779f7c6dae9b0de98a19ba452111fea5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants