New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set InspectorFlags in RCTAppDelegate #41976

Closed

huntie wants to merge 1 commit into facebook:main from huntie:export-D51589221

Member

huntie commented Dec 18, 2023 •

edited

Loading

Summary:
Progress towards an opt-in setup for our new CDP backend.

Wires up D51563107 to conditionally disable the legacy Hermes debugger via ReactNativeConfig.
- Configuration covered: iOS, for the RCTAppDelegate code path.
Create C++-only overload of RCTAppSetupPrepareApp, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate RCTAppSetupPrepareApp, replaced with C++ overload

Reviewed By: motiz88

Differential Revision: D51589221

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Dec 18, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

facebook-github-bot added the fb-exported label

analysis-bot commented Dec 18, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,525,143	+9
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	19,899,942	-7
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 1045b22
Branch: main

huntie force-pushed the export-D51589221 branch from 4ab8581 to fbc11e3 Compare

December 19, 2023 11:53

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

fbc11e3

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.

Changelog:
[iOS][Breaking] - API change for integrators: `RCTAppSetupPrepareApp` now requires a `reactNativeConfig` argument

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from fbc11e3 to f284eef Compare

December 19, 2023 11:55

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

f284eef

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with `RCTAppSetupPrepareAppWithConfig`

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from f284eef to 9e786e3 Compare

December 19, 2023 11:57

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

9e786e3

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with `RCTAppSetupPrepareAppWithConfig`

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from 9e786e3 to 57ff3ef Compare

December 19, 2023 11:58

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

57ff3ef

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with `RCTAppSetupPrepareAppWithConfig`

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from 57ff3ef to 1fb2eb7 Compare

December 19, 2023 12:09

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

1fb2eb7

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from 1fb2eb7 to bd29d7f Compare

December 19, 2023 12:10

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

bd29d7f

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from bd29d7f to c4d8e76 Compare

December 19, 2023 16:01

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

c4d8e76

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Reviewed By: motiz88

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

0f5b401

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Reviewed By: motiz88

Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from c4d8e76 to dd60aab Compare

December 19, 2023 16:02

huntie added a commit to huntie/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

dd60aab

Summary:

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Reviewed By: motiz88

Differential Revision: D51589221

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

huntie force-pushed the export-D51589221 branch from dd60aab to 0f5b401 Compare

December 19, 2023 16:02

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request was exported from Phabricator. Differential Revision: D51589221

facebook-github-bot closed this in

7a4950b

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Dec 19, 2023

This pull request has been merged in 7a4950b.

Othinn pushed a commit to Othinn/react-native that referenced this pull request


          Set InspectorFlags in RCTAppDelegate (facebook#41976)

1b6ee8f

Summary:
Pull Request resolved: facebook#41976

Progress towards an opt-in setup for our new CDP backend.

- Wires up D51563107 to conditionally disable the legacy Hermes debugger via `ReactNativeConfig`.
    - **Configuration covered**: iOS, for the `RCTAppDelegate` code path.
- Create C++-only overload of `RCTAppSetupPrepareApp`, deprecate the previous function.

Changelog:
[iOS][Deprecated] - Deprecate `RCTAppSetupPrepareApp`, replaced with C++ overload

Reviewed By: motiz88

Differential Revision: D51589221

fbshipit-source-id: 1688f97c69abb06d271b4d26b875365a8d86ba77

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

01c90b1

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

huntie mentioned this pull request

Remove RCTAppSetupPrepareApp overload and InspectorFlags call #42642

Closed

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

047924c

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

acea004

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: a0ae2391762c28af114c56f1dffee644c90b7045

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

e3b67b6

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: 2c8a9ea123d48cdf8784427f9ecb06cdd2b588a3

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

dc07262

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: cd7295b2f3541f6a3e1ae66228590cbf61561009

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

48315ad

…ok#42642)

Summary:
Pull Request resolved: facebook#42642

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: 8ed5e3874c7c8e8bd24556ea25c2818823f299b4

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

26a3db3

…ok#42642)

Summary:
Pull Request resolved: facebook#42642

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: 457f55cbccea8b5b3fbfbbd0c44c5b98dff6834a

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

ec865f9

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: efe011b29d4f2de7d0d4c6ca85219e872715941a

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

1ba9a16

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          [skip ci] Remove RCTAppSetupPrepareApp overload and InspectorFlags ca…

3fc9d2f

…ll (facebook#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call

b7c2cc0

Summary:
Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Differential Revision: D53048207

fbshipit-source-id: 31549c4ff9c11a5bd0e6d2887ca4063a3cf63c85

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

c35b5b8

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

f4c6290

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

1a6730c

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207

huntie added a commit to huntie/react-native that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (facebo…

b73a9e6

…ok#42642)

Summary:

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976)

Reviewed By: motiz88

Differential Revision: D53048207

facebook-github-bot pushed a commit that referenced this pull request


          Remove RCTAppSetupPrepareApp overload and InspectorFlags call (#42642)

ce3ce11

Summary:
Pull Request resolved: #42642

Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation.

Changelog:
[iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts #41976)

Reviewed By: motiz88

Differential Revision: D53048207

fbshipit-source-id: 8624020f1e9e19f9f1ee75af9b177e922e36c5d9

huntie deleted the export-D51589221 branch

February 16, 2024 15:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner