Improve setting props of the Interop Layer #41942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51755764 |
…41941) Summary: While working on the interop layer, I realized that htis code is duplicated. ## Changelog [Internal] - Use the same method for View And ShadowView in the Interop layer Reviewed By: sammy-SC Differential Revision: D51752171
Summary: Previously, every time a component was updated, we were passing all the props to the interoperated component. With this change, we are going to only pass the props that are changed. As a safety feature, if the new codepath is not able to detect the type of the prop properly, it will fall back to the previous behavior. ## Changelog: [Internal] - Only pass props to the interoperated component when they changes Reviewed By: sammy-SC Differential Revision: D51755764
cipolleschi
force-pushed
the
export-D51755764
branch
from
943375f to
ea24f12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51755764 |
Base commit: 8183afe |
|
This pull request has been merged in b098297. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41942 Previously, every time a component was updated, we were passing all the props to the interoperated component. With this change, we are going to only pass the props that are changed. As a safety feature, if the new codepath is not able to detect the type of the prop properly, it will fall back to the previous behavior. ## Changelog: [Internal] - Only pass props to the interoperated component when they changes Reviewed By: sammy-SC Differential Revision: D51755764 fbshipit-source-id: 0185d2cceeab2a1e45b87d5a1e82ab06e00aa82d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, every time a component was updated, we were passing all the props to the interoperated component.
With this change, we are going to only pass the props that are changed.
As a safety feature, if the new codepath is not able to detect the type of the prop properly, it will fall back to the previous behavior.
Changelog:
[Internal] - Only pass props to the interoperated component when they changes
Reviewed By: sammy-SC
Differential Revision: D51755764