feat[DebuggingRegistry]: basic implementation #41743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 1, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787
hoxyq
force-pushed
the
export-D51536787
branch
from
241928a to
1eec446
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 1, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 1, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787
hoxyq
force-pushed
the
export-D51536787
branch
from
1eec446 to
57f9a9f
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
force-pushed
the
export-D51536787
branch
from
57f9a9f to
3bba51a
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 6, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
force-pushed
the
export-D51536787
branch
from
3bba51a to
ae8e111
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 7, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 7, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 7, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Dec 7, 2023
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
Summary: Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Reviewed By: rshest Differential Revision: D51536787
hoxyq
force-pushed
the
export-D51536787
branch
from
ae8e111 to
748f4e3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51536787 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 4, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: cf24bd0bdcd411e7529c591096cd3416ae07d95d
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 4, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: f2b60b5326c7b6a5c14a584e92f291bfb9f1c557
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 4, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: f424e04e042e1243feaf621c169af682f90342e8
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 5, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 9903860be00df859302c1e500b00ef9281c16823
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 5, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 8b61d58ccd1bdd7370c833acc15e653fa8579c34
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 5, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: fe3d19ea4ad2a0bccb186d4cb472535be154093d
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 097b1fbd1955957abd7a29c5235b0ddc8a26373d
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 8c505d213e18eaae7b907d3536ba157ac21164b1
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 8bbab4f0aa95aa66f1e29b0dca7d34c5819ce273
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 8, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 5f298b6bd6499bbb9c1195106e175e56cabeb89b
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 11, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 286bfd5d70616181502e4c304499af74ee5c37f6
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 11, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 3f1545ad89c1c601fe350045f096c3f4ddd2d84b
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 11, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: b1fb85138be798d57a483c9eea41f62856c1f0fb
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 95bac8098e293bfa13afae755706fbfc4f520e2e
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: ee82c3bc275b0d2951742c73dbf58d3d7a497b29
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 54105dd86b0ca0e27dd64f1b636e82efab1ab2c4
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: 828ca7f90c67c5ce5b49ffb42bd36bfc0fd282e8
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
Summary: Pull Request resolved: facebook#41743 Changelog: [Internal] There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component. It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods. In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements. Differential Revision: D51536787 Reviewed By: rshest fbshipit-source-id: a6a64ef5f2cec6eb10881275929272ce02038c20
|
This pull request has been merged in f8a1818. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
There will be a single DebuggingRegistry instance per runtime, which will be responsible for finding lowest AppContainer ancestor for highligthed component.
It will receive refs to root views (ancestors, AppContainers) as subscriptions and later will call all necessary methods.
In the next series of diffs, subscriber will also provide reference to the DebuggingOverlay, on which DebuggingRegistry can call all necessary methods to highlight elements.
Differential Revision: D51536787