avoid scheduling frame callback if there are no events #41658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50604303 |
Base commit: eb7e10b |
Summary: changelog: [internal] FabricEventDispatcher does not need to run on every frame. Whenever a new event is added to Fabric's event queue, it will call `FabricUIManager.onRequestEventBeat` in Java. This in turn calls `FabricEventDispatcher.maybePostFrameCallbackFromNonUI` and adds a frame callback on the Choreographer. This makes code simpler, as we do not need to manage the frame callback subscription. Reviewed By: sammy-SC Differential Revision: D50604303
gpalves
force-pushed
the
export-D50604303
branch
from
2f80479 to
b108f4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50604303 |
|
This pull request has been merged in 86c5aba. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41658 changelog: [internal] FabricEventDispatcher does not need to run on every frame. Whenever a new event is added to Fabric's event queue, it will call `FabricUIManager.onRequestEventBeat` in Java. This in turn calls `FabricEventDispatcher.maybePostFrameCallbackFromNonUI` and adds a frame callback on the Choreographer. This makes code simpler, as we do not need to manage the frame callback subscription. Reviewed By: sammy-SC Differential Revision: D50604303 fbshipit-source-id: ce2c7b77678bfc14aa7ecac71e40f78263c7036a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
FabricEventDispatcher does not need to run on every frame. Whenever a new event is added to Fabric's event queue, it will call
FabricUIManager.onRequestEventBeatin Java. This in turn callsFabricEventDispatcher.maybePostFrameCallbackFromNonUIand adds a frame callback on the Choreographer.This makes code simpler, as we do not need to manage the frame callback subscription.
Reviewed By: sammy-SC
Differential Revision: D50604303