Refactor generate-artifacts-executor.js: delete handleLibrariesFromReactNativeConfig #41654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51308595 |
Base commit: ef9c164 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 27, 2023
…actNativeConfig (facebook#41654) Summary: This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Differential Revision: D51308595
dmytrorykun
force-pushed
the
export-D51308595
branch
from
3b20424 to
df01434
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51308595 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 27, 2023
…actNativeConfig (facebook#41654) Summary: This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Differential Revision: D51308595
dmytrorykun
force-pushed
the
export-D51308595
branch
from
df01434 to
171991f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51308595 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 27, 2023
…actNativeConfig (facebook#41654) Summary: This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Differential Revision: D51308595
…actNativeConfig (facebook#41654) Summary: This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Reviewed By: cipolleschi Differential Revision: D51308595
dmytrorykun
force-pushed
the
export-D51308595
branch
from
171991f to
1f18a01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51308595 |
|
This pull request was successfully merged by @dmytrorykun in ca39a11. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in ca39a11. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…actNativeConfig (facebook#41654) Summary: Pull Request resolved: facebook#41654 This diff removes support for defining external codegen targets in `react-native.config.js` for iOS. Now you can simply add your external dependency to the project's `package.json` and it will be resolved as a normal Node packages. ## Motivation The need for defining external codegen targets in `react-native.config.js` historically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed in `react-native.config.js`. After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies. Changelog: [iOS][Breaking] - Defining external codegen targets in `react-native.config.js` is not supported anymore. Define them as normal dependencies in `package.json`. Reviewed By: cipolleschi Differential Revision: D51308595 fbshipit-source-id: 97841a3a8c295aa717c577bb188d48373b04ba38
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 31, 2024
…act-native.config.js Summary: This feature was first introduced here facebook#34580 And then removed here facebook#41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [Internal] Differential Revision: D53267857
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Feb 1, 2024
…act-native.config.js (facebook#42771) Summary: This feature was first introduced here facebook#34580 And then removed here facebook#41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js Reviewed By: cipolleschi Differential Revision: D53267857
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
…act-native.config.js (#42771) Summary: Pull Request resolved: #42771 This feature was first introduced here #34580 And then removed here #41654 The motivation for its removing was that Node resolver should handle all those cases for which `react-native.config.js` was used. But it turns out that it fails for the setup that `react-native-builder-bob` has. This diff brings back support for defining external libraries in `react-native.config.js`. Changelog: [iOS][Fixed] - Bring back support for defining external libraries in react-native.config.js Reviewed By: cipolleschi Differential Revision: D53267857 fbshipit-source-id: 7625dfe7b4a4651eb60eaec725f94f222a244e30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff removes support for defining external codegen targets in
react-native.config.jsfor iOS. Now you can simply add your external dependency to the project'spackage.jsonand it will be resolved as a normal Node packages.Motivation
The need for defining external codegen targets in
react-native.config.jshistorically appeared due to limitations of how codegen searched for external dependencies. Basically we performed search only in the project directory. External dependency paths had to be listed inreact-native.config.js.After D51303793 has landed we don't need this any longer. We can simply rely on Node resolution to find those external dependencies.
Changelog: [iOS][Breaking] - Defining external codegen targets in
react-native.config.jsis not supported anymore. Define them as normal dependencies inpackage.json.Differential Revision: D51308595