Refactor generate-artifacts-executor.js: remove configFileDir CLI argument, use node resolution instead #41557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
force-pushed
the
export-D51303793
branch
from
6d383a9 to
5cb9b8c
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: Pull Request resolved: facebook#41557 The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: D51303793 fbshipit-source-id: 9dce65510940641084185b32308bab7cab5c4588
dmytrorykun
force-pushed
the
export-D51303793
branch
from
5cb9b8c to
9936b23
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: D51303793
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: D51303793
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: Pull Request resolved: facebook#41557 The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: https://internalfb.com/D51303793 fbshipit-source-id: d9ce526b56f387f4af696a744e2faeead7fd37c7
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: Pull Request resolved: facebook#41557 The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: https://internalfb.com/D51303793 fbshipit-source-id: c27d28c1598bcf9493290a9397a0480515065d82
dmytrorykun
force-pushed
the
export-D51303793
branch
from
9936b23 to
d9251b5
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: D51303793
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…ument, use node resolution instead (facebook#41557) Summary: Pull Request resolved: facebook#41557 The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Differential Revision: https://internalfb.com/D51303793 fbshipit-source-id: 567fbaa683b336c7c7a95ff658893cc9554a384c
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
dmytrorykun
force-pushed
the
export-D51303793
branch
from
d9251b5 to
b3b96c0
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
Base commit: 6b89dc1 |
dmytrorykun
force-pushed
the
export-D51303793
branch
from
b3b96c0 to
622b9de
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
dmytrorykun
force-pushed
the
export-D51303793
branch
from
622b9de to
bed0d4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
dmytrorykun
force-pushed
the
export-D51303793
branch
from
bed0d4c to
e6b37ed
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 23, 2023
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
…ument, use node resolution instead (facebook#41557) Summary: The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793
dmytrorykun
force-pushed
the
export-D51303793
branch
from
e6b37ed to
3477cc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51303793 |
|
This pull request has been merged in 8a62d61. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ument, use node resolution instead (facebook#41557) Summary: Pull Request resolved: facebook#41557 The `configFileDir` CLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the root `package.json`, we can use `node` resolution instead of having to construct paths manually. In that case `configFileDir` becomes redundant. Changelog: [iOS][Breaking] - Delete configFileDir CLI argument. Reviewed By: cipolleschi Differential Revision: D51303793 fbshipit-source-id: 46cb61197ddf51515af634c8fc6b85a8d218c51e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
configFileDirCLI argument is used to help to find paths to the 3rd party dependencies of the app. Since we only care about dependencies listed in the rootpackage.json, we can usenoderesolution instead of having to construct paths manually. In that caseconfigFileDirbecomes redundant.Changelog: [iOS][Breaking] - Delete configFileDir CLI argument.
Differential Revision: D51303793